From 49aaaf1053d5f12e2c990c5342e1fea7fd1138a6 Mon Sep 17 00:00:00 2001 From: kjellander Date: Thu, 18 May 2017 23:46:01 -0700 Subject: [PATCH] Remove CheckChangeHasTestField PRESUBMIT check. Depot tools removed it in https://chromium-review.googlesource.com/c/506450/ so we don't have a choice. We never enforced it or had it connected to any organized follow-up anyway, so it makes sense to remove it. BUG=None TBR=ehmaldonado@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2892873002 Cr-Commit-Position: refs/heads/master@{#18205} --- PRESUBMIT.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index fe1acfe7ee..843e1e6a44 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -598,8 +598,6 @@ def CheckChangeOnCommit(input_api, output_api): results.extend(input_api.canned_checks.CheckChangeHasDescription( input_api, output_api)) results.extend(_CheckChangeHasBugField(input_api, output_api)) - results.extend(input_api.canned_checks.CheckChangeHasTestField( - input_api, output_api)) results.extend(input_api.canned_checks.CheckTreeIsOpen( input_api, output_api, json_url='http://webrtc-status.appspot.com/current?format=json'))