From 491ff3d54c4d0ebe78e7b1bd7e71db6b80005dc5 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Sun, 12 Apr 2020 18:00:52 +0200 Subject: [PATCH] Remove AudioProcessing::UpdateHistogramsOnCallEnd. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: webrtc:10198 Change-Id: I3e7a98f9b94c171e7f105883fc755e44b2e991ae Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/173464 Reviewed-by: Per Åhgren Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#31070} --- modules/audio_processing/audio_processing_impl.cc | 2 -- modules/audio_processing/audio_processing_impl.h | 1 - modules/audio_processing/include/audio_processing.h | 6 ------ modules/audio_processing/include/mock_audio_processing.h | 1 - 4 files changed, 10 deletions(-) diff --git a/modules/audio_processing/audio_processing_impl.cc b/modules/audio_processing/audio_processing_impl.cc index e5e6ccef60..34e64251b8 100644 --- a/modules/audio_processing/audio_processing_impl.cc +++ b/modules/audio_processing/audio_processing_impl.cc @@ -1913,8 +1913,6 @@ void AudioProcessingImpl::InitializePreProcessor() { } } -void AudioProcessingImpl::UpdateHistogramsOnCallEnd() {} - void AudioProcessingImpl::WriteAecDumpConfigMessage(bool forced) { if (!aec_dump_) { return; diff --git a/modules/audio_processing/audio_processing_impl.h b/modules/audio_processing/audio_processing_impl.h index 258e2e1424..65ab5a60cd 100644 --- a/modules/audio_processing/audio_processing_impl.h +++ b/modules/audio_processing/audio_processing_impl.h @@ -69,7 +69,6 @@ class AudioProcessingImpl : public AudioProcessing { int Initialize(const ProcessingConfig& processing_config) override; void ApplyConfig(const AudioProcessing::Config& config) override; void SetExtraOptions(const webrtc::Config& config) override; - void UpdateHistogramsOnCallEnd() override; void AttachAecDump(std::unique_ptr aec_dump) override; void DetachAecDump() override; void AttachPlayoutAudioGenerator( diff --git a/modules/audio_processing/include/audio_processing.h b/modules/audio_processing/include/audio_processing.h index 265507dd66..7daac86ee3 100644 --- a/modules/audio_processing/include/audio_processing.h +++ b/modules/audio_processing/include/audio_processing.h @@ -624,12 +624,6 @@ class RTC_EXPORT AudioProcessing : public rtc::RefCountInterface { // attached, its destructor is called. virtual void DetachPlayoutAudioGenerator() = 0; - // Use to send UMA histograms at end of a call. Note that all histogram - // specific member variables are reset. - // Deprecated. This method is deprecated and will be removed. - // TODO(peah): Remove this method. - virtual void UpdateHistogramsOnCallEnd() = 0; - // Get audio processing statistics. virtual AudioProcessingStats GetStatistics() = 0; // TODO(webrtc:5298) Deprecated variant. The |has_remote_tracks| argument diff --git a/modules/audio_processing/include/mock_audio_processing.h b/modules/audio_processing/include/mock_audio_processing.h index 66c5831e79..2346489b2a 100644 --- a/modules/audio_processing/include/mock_audio_processing.h +++ b/modules/audio_processing/include/mock_audio_processing.h @@ -136,7 +136,6 @@ class MockAudioProcessing : public ::testing::NiceMock { std::unique_ptr audio_generator) {} MOCK_METHOD0(DetachPlayoutAudioGenerator, void()); - MOCK_METHOD0(UpdateHistogramsOnCallEnd, void()); MOCK_METHOD0(GetStatistics, AudioProcessingStats()); MOCK_METHOD1(GetStatistics, AudioProcessingStats(bool));