From 488c5dcd8be47454344d767e2d0962f0fec45658 Mon Sep 17 00:00:00 2001
From: perkj <perkj@webrtc.org>
Date: Wed, 8 Feb 2017 05:55:51 -0800
Subject: [PATCH] Add new target direct_transport and remove fake_network and
 direct_transport from test_common. The purpose is to be able to use this
 feature without building and using all of test_common. However, test_common
 still builds call_test.cc that is depending on direct_transport.

BUG=none

Review-Url: https://codereview.webrtc.org/2686633002
Cr-Commit-Position: refs/heads/master@{#16494}
---
 webrtc/test/BUILD.gn            | 25 ++++++++++++++++++++-----
 webrtc/test/direct_transport.cc |  1 -
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/webrtc/test/BUILD.gn b/webrtc/test/BUILD.gn
index 0e885c84b4..a4c018524f 100644
--- a/webrtc/test/BUILD.gn
+++ b/webrtc/test/BUILD.gn
@@ -312,6 +312,25 @@ rtc_source_set("fileutils_unittests") {
   ]
 }
 
+rtc_source_set("direct_transport") {
+  testonly = true
+  sources = [
+    "direct_transport.cc",
+    "direct_transport.h",
+    "fake_network_pipe.cc",
+    "fake_network_pipe.h",
+  ]
+  if (!build_with_chromium && is_clang) {
+    # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
+    suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
+  }
+  deps = [
+    "../api:transport_api",
+    "../base:rtc_base_approved",
+    "../call",
+  ]
+}
+
 rtc_source_set("test_common") {
   testonly = true
   sources = [
@@ -321,8 +340,6 @@ rtc_source_set("test_common") {
     "configurable_frame_size_encoder.h",
     "constants.cc",
     "constants.h",
-    "direct_transport.cc",
-    "direct_transport.h",
     "drifting_clock.cc",
     "drifting_clock.h",
     "encoder_settings.cc",
@@ -333,8 +350,6 @@ rtc_source_set("test_common") {
     "fake_decoder.h",
     "fake_encoder.cc",
     "fake_encoder.h",
-    "fake_network_pipe.cc",
-    "fake_network_pipe.h",
     "fake_videorenderer.h",
     "layer_filtering_transport.cc",
     "layer_filtering_transport.h",
@@ -361,10 +376,10 @@ rtc_source_set("test_common") {
   }
 
   deps = [
+    ":direct_transport",
     ":rtp_test_utils",
     ":test_support",
     "..:webrtc_common",
-    "../api:transport_api",
     "../audio",
     "../base:rtc_base_approved",
     "../call",
diff --git a/webrtc/test/direct_transport.cc b/webrtc/test/direct_transport.cc
index a5bd05a3c2..922874d111 100644
--- a/webrtc/test/direct_transport.cc
+++ b/webrtc/test/direct_transport.cc
@@ -11,7 +11,6 @@
 
 #include "webrtc/call/call.h"
 #include "webrtc/system_wrappers/include/clock.h"
-#include "webrtc/test/gtest.h"
 
 namespace webrtc {
 namespace test {