From 486cb1853107e118465b9b3ee2cf095de9321f09 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 20 Jul 2018 13:37:11 +0200 Subject: [PATCH] Enable clang::find_bad_constructs for rtc_tools (part 1/2). This CL removes //build/config/clang:find_bad_constructs from the suppressed_configs list, which means that clang:find_bad_constructs is now enabled on these translation units. Bug: webrtc:9251, webrtc:163 Change-Id: I9c26b6129db24263f1aada9561f477db64091049 Reviewed-on: https://webrtc-review.googlesource.com/89742 Reviewed-by: Oleh Prypin Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#24051} --- rtc_tools/BUILD.gn | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn index dc5f193232..dcb3818c60 100644 --- a/rtc_tools/BUILD.gn +++ b/rtc_tools/BUILD.gn @@ -145,11 +145,6 @@ if (!build_with_chromium) { "frame_editing/frame_editing_lib.h", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "..:webrtc_common", "../:typedefs", @@ -176,11 +171,6 @@ if (!build_with_chromium) { "force_mic_volume_max/force_mic_volume_max.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../modules/audio_device", "../modules/audio_device:audio_device_impl", @@ -283,11 +273,6 @@ if (rtc_include_tests) { "agc/activity_metric.cc", ] - if (!build_with_chromium && is_clang) { - # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). - suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] - } - deps = [ "../api/audio:audio_frame_api", "../modules/audio_processing/agc:level_estimation",