admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Force -Wno-shadow to avoid variable shadowing warnings.

Browse Source 
Long term, ideally, these would be fixed and this flag can be removed.
For now, this is an expedient way to allow enabling -Wshadow in
Chromium.

Bug: chromium:794619
Change-Id: I7aba1c7bb7dfe0598cdb077cb97def752b8bac79
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/232660
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#35110}
This commit is contained in:
Peter Kasting 2021-09-28 10:08:54 -07:00 committed by WebRTC LUCI CQ
parent 5da581b564
commit 47126fa536
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
BUILD.gn
View File

@ -305,7 +305,10 @@ config("common_config") {
defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ] defines += [ "WEBRTC_EXCLUDE_AUDIO_PROCESSING_MODULE" ]
} }
cflags = [] # TODO(webrtc:13219): Fix -Wshadow instances and enable.
if (is_clang) {
cflags += [ "-Wno-shadow" ]
}
if (build_with_chromium) { if (build_with_chromium) {
defines += [ defines += [