From 45448e9c1c21cac0761bf6942ee26d952f7e4bab Mon Sep 17 00:00:00 2001 From: Evan Shrubsole Date: Mon, 15 Nov 2021 17:27:44 +0100 Subject: [PATCH] Remove slow_tests repeating_task_unittests no longer relies on sleeps, so slow_tests is no longer needed. Bug: webrtc:12808 Change-Id: Ie9ad23e065074638fe3770e51fb7be83344160e7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/237804 Reviewed-by: Mirko Bonadei Commit-Queue: Evan Shrubsole Cr-Commit-Position: refs/heads/main@{#35351} --- BUILD.gn | 13 +------------ tools_webrtc/coverage/generate_coverage_command.py | 2 +- .../coverage/generate_ios_coverage_command.py | 1 - tools_webrtc/mb/gn_isolate_map.pyl | 4 ---- 4 files changed, 2 insertions(+), 18 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 215c74c525..85a45c17f1 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -39,7 +39,6 @@ if (!build_with_chromium) { if (rtc_include_tests) { deps += [ ":rtc_unittests", - ":slow_tests", ":video_engine_tests", ":voip_unittests", ":webrtc_nonparallel_tests", @@ -576,6 +575,7 @@ if (rtc_include_tests && !build_with_chromium) { "rtc_base/experiments:experiments_unittests", "rtc_base/system:file_wrapper_unittests", "rtc_base/task_utils:pending_task_safety_flag_unittests", + "rtc_base/task_utils:repeating_task_unittests", "rtc_base/task_utils:to_queued_task_unittests", "sdk:sdk_tests", "test:rtp_test_utils", @@ -614,17 +614,6 @@ if (rtc_include_tests && !build_with_chromium) { } } - # This runs tests that must run in real time and therefore can take some - # time to execute. They are in a separate executable to avoid making the - # regular unittest suite too slow to run frequently. - rtc_test("slow_tests") { - testonly = true - deps = [ - "rtc_base/task_utils:repeating_task_unittests", - "test:test_main", - ] - } - # TODO(pbos): Rename test suite, this is no longer "just" for video targets. video_engine_tests_resources = [ "resources/foreman_cif_short.yuv", diff --git a/tools_webrtc/coverage/generate_coverage_command.py b/tools_webrtc/coverage/generate_coverage_command.py index 894731b8b7..7c701f8b55 100644 --- a/tools_webrtc/coverage/generate_coverage_command.py +++ b/tools_webrtc/coverage/generate_coverage_command.py @@ -17,7 +17,7 @@ import sys TESTS = [ 'video_capture_tests', 'webrtc_nonparallel_tests', 'video_engine_tests', - 'tools_unittests', 'test_support_unittests', 'slow_tests', + 'tools_unittests', 'test_support_unittests', 'system_wrappers_unittests', 'rtc_unittests', 'rtc_stats_unittests', 'rtc_pc_unittests', 'rtc_media_unittests', 'peerconnection_unittests', 'modules_unittests', 'modules_tests', 'low_bandwidth_audio_test', diff --git a/tools_webrtc/coverage/generate_ios_coverage_command.py b/tools_webrtc/coverage/generate_ios_coverage_command.py index 4feaacd868..e51bfa7206 100644 --- a/tools_webrtc/coverage/generate_ios_coverage_command.py +++ b/tools_webrtc/coverage/generate_ios_coverage_command.py @@ -61,7 +61,6 @@ TESTS = [ 'rtc_pc_unittests', 'rtc_stats_unittests', 'rtc_unittests', - 'slow_tests', 'system_wrappers_unittests', 'test_support_unittests', 'tools_unittests', diff --git a/tools_webrtc/mb/gn_isolate_map.pyl b/tools_webrtc/mb/gn_isolate_map.pyl index 01993a8fcb..ac69f80bc0 100644 --- a/tools_webrtc/mb/gn_isolate_map.pyl +++ b/tools_webrtc/mb/gn_isolate_map.pyl @@ -118,10 +118,6 @@ "label": "//sdk:sdk_unittests", "type": "raw", }, - "slow_tests": { - "label": "//:slow_tests", - "type": "console_test_launcher", - }, "system_wrappers_unittests": { "label": "//system_wrappers:system_wrappers_unittests", "type": "console_test_launcher",