diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn index 6f1d429f85..9e5bdc671b 100644 --- a/webrtc/base/BUILD.gn +++ b/webrtc/base/BUILD.gn @@ -368,6 +368,25 @@ config("rtc_base_warnings_config") { } } +rtc_source_set("rtc_json") { + defines = [] + sources = [ + "json.cc", + "json.h", + ] + if (rtc_build_json) { + public_deps = [ + "//third_party/jsoncpp", + ] + } else { + include_dirs = [ "$rtc_jsoncpp_root" ] + + # When defined changes the include path for json.h to where it is + # expected to be when building json outside of the standalone build. + defines += [ "WEBRTC_EXTERNAL_JSON" ] + } +} + rtc_static_library("rtc_base") { cflags = [] cflags_cc = [] @@ -503,8 +522,6 @@ rtc_static_library("rtc_base") { configs += [ ":rtc_base_warnings_config" ] sources += [ "callback.h", - "json.cc", - "json.h", "logsinks.cc", "logsinks.h", "mathutils.h", @@ -530,16 +547,6 @@ rtc_static_library("rtc_base") { "win32socketserver.h", ] } - - if (rtc_build_json) { - deps += [ "//third_party/jsoncpp" ] - } else { - include_dirs = [ "$rtc_jsoncpp_root" ] - - # When defined changes the include path for json.h to where it is - # expected to be when building json outside of the standalone build. - defines += [ "WEBRTC_EXTERNAL_JSON" ] - } } # !build_with_chromium if (rtc_build_ssl) { diff --git a/webrtc/examples/BUILD.gn b/webrtc/examples/BUILD.gn index a33ecc70b0..80b3efaf81 100644 --- a/webrtc/examples/BUILD.gn +++ b/webrtc/examples/BUILD.gn @@ -517,15 +517,13 @@ if (is_linux || is_win) { "//webrtc/api:video_frame_api", "//webrtc/base:rtc_base", "//webrtc/base:rtc_base_approved", + "//webrtc/base:rtc_json", "//webrtc/media:rtc_media", "//webrtc/modules/video_capture:video_capture_module", "//webrtc/pc:libjingle_peerconnection", "//webrtc/system_wrappers:field_trial_default", "//webrtc/system_wrappers:metrics_default", ] - if (rtc_build_json) { - deps += [ "//third_party/jsoncpp" ] - } } rtc_executable("peerconnection_server") { diff --git a/webrtc/p2p/BUILD.gn b/webrtc/p2p/BUILD.gn index 3141c522ec..e4770cc462 100644 --- a/webrtc/p2p/BUILD.gn +++ b/webrtc/p2p/BUILD.gn @@ -91,13 +91,6 @@ rtc_static_library("rtc_p2p") { "../system_wrappers:field_trial_api", ] - if (rtc_build_expat) { - deps += [ "//third_party/expat" ] - public_deps = [ - "//third_party/expat", - ] - } - public_configs = [ ":rtc_p2p_inherited_config" ] if (build_with_chromium) { diff --git a/webrtc/webrtc.gni b/webrtc/webrtc.gni index e47ac08afc..5e1c12dd3f 100644 --- a/webrtc/webrtc.gni +++ b/webrtc/webrtc.gni @@ -78,7 +78,6 @@ declare_args() { rtc_enable_sctp = true # Disable these to not build components which can be externally provided. - rtc_build_expat = true rtc_build_json = true rtc_build_libjpeg = true rtc_build_libsrtp = true