From 444c13c078a7e9bb2174419e12113e39929551d8 Mon Sep 17 00:00:00 2001 From: Byoungchan Lee Date: Wed, 2 Sep 2020 18:08:36 +0900 Subject: [PATCH] Fix tests in WebRtcVideoChannelBaseTest. If rtc_libvpx_build_vp9=false, some tests fail because BuiltinVideoEncoderFactory / DecoderFactory doesn't support VP9. Bug: webrtc:11901 Change-Id: Iaa97950e70e1f70cdeb6ef677786e0fd115a75db Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/183220 Reviewed-by: Niels Moller Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/master@{#32028} --- media/engine/webrtc_video_engine_unittest.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/media/engine/webrtc_video_engine_unittest.cc b/media/engine/webrtc_video_engine_unittest.cc index 8b45c6582f..6d2e971f76 100644 --- a/media/engine/webrtc_video_engine_unittest.cc +++ b/media/engine/webrtc_video_engine_unittest.cc @@ -2262,6 +2262,8 @@ TEST_F(WebRtcVideoChannelBaseTest, TwoStreamsSendAndReceive) { TwoStreamsSendAndReceive(codec); } +#if defined(RTC_ENABLE_VP9) + TEST_F(WebRtcVideoChannelBaseTest, RequestEncoderFallback) { cricket::VideoSendParameters parameters; parameters.codecs.push_back(GetEngineCodec("VP9")); @@ -2398,6 +2400,8 @@ TEST_F(WebRtcVideoChannelBaseTest, EXPECT_THAT(codec.params, Contains(Pair(kParam, kPing))); } +#endif // defined(RTC_ENABLE_VP9) + class WebRtcVideoChannelTest : public WebRtcVideoEngineTest { public: WebRtcVideoChannelTest() : WebRtcVideoChannelTest("") {}