From 4371d4650ab2c1bbfa3b97133100ddf33312a199 Mon Sep 17 00:00:00 2001 From: "aluebs@webrtc.org" Date: Tue, 14 Jan 2014 08:57:22 +0000 Subject: [PATCH] Temporarily disabling some more audio processing tests. R=andrew@webrtc.org, bjornv@webrtc.org, xians@webrtc.org Review URL: https://webrtc-codereview.appspot.com/7019005 git-svn-id: http://webrtc.googlecode.com/svn/trunk@5380 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../test/auto_test/extended/agc_config_test.cc | 14 ++++++++------ .../auto_test/standard/audio_processing_test.cc | 10 +++++----- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc index 384fa1e9c3..c706cb738a 100644 --- a/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc +++ b/webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc @@ -22,7 +22,9 @@ class AgcConfigTest : public AfterStreamingFixture { webrtc::AgcConfig default_agc_config_; }; -TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) { +// TODO(aluebs): Re-enable tests in agc_config_test and audio_processing_test +// when possible. Bug: issue 2784. +TEST_F(AgcConfigTest, DISABLED_HasCorrectDefaultConfiguration) { webrtc::AgcConfig agc_config; EXPECT_EQ(0, voe_apm_->GetAgcConfig(agc_config)); @@ -33,7 +35,7 @@ TEST_F(AgcConfigTest, HasCorrectDefaultConfiguration) { EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable); } -TEST_F(AgcConfigTest, DealsWithInvalidParameters) { +TEST_F(AgcConfigTest, DISABLED_DealsWithInvalidParameters) { webrtc::AgcConfig agc_config = default_agc_config_; agc_config.digitalCompressionGaindB = 91; EXPECT_EQ(-1, voe_apm_->SetAgcConfig(agc_config)) << "Should not be able " @@ -47,7 +49,7 @@ TEST_F(AgcConfigTest, DealsWithInvalidParameters) { EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError()); } -TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) { +TEST_F(AgcConfigTest, DISABLED_CanGetAndSetAgcStatus) { webrtc::AgcConfig agc_config; agc_config.digitalCompressionGaindB = 17; agc_config.targetLeveldBOv = 11; @@ -65,7 +67,7 @@ TEST_F(AgcConfigTest, CanGetAndSetAgcStatus) { actual_config.targetLeveldBOv); } -TEST_F(AgcConfigTest, HasCorrectDefaultRxConfiguration) { +TEST_F(AgcConfigTest, DISABLED_HasCorrectDefaultRxConfiguration) { webrtc::AgcConfig agc_config; EXPECT_EQ(0, voe_apm_->GetRxAgcConfig(channel_, agc_config)); @@ -76,7 +78,7 @@ TEST_F(AgcConfigTest, HasCorrectDefaultRxConfiguration) { EXPECT_EQ(default_agc_config_.limiterEnable, agc_config.limiterEnable); } -TEST_F(AgcConfigTest, DealsWithInvalidRxParameters) { +TEST_F(AgcConfigTest, DISABLED_DealsWithInvalidRxParameters) { webrtc::AgcConfig agc_config = default_agc_config_; agc_config.digitalCompressionGaindB = 91; EXPECT_EQ(-1, voe_apm_->SetRxAgcConfig(channel_, agc_config)) << @@ -90,7 +92,7 @@ TEST_F(AgcConfigTest, DealsWithInvalidRxParameters) { EXPECT_EQ(VE_APM_ERROR, voe_base_->LastError()); } -TEST_F(AgcConfigTest, CanGetAndSetRxAgcStatus) { +TEST_F(AgcConfigTest, DISABLED_CanGetAndSetRxAgcStatus) { webrtc::AgcConfig agc_config; agc_config.digitalCompressionGaindB = 17; agc_config.targetLeveldBOv = 11; diff --git a/webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc b/webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc index 132caa3e91..928387fd85 100644 --- a/webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc +++ b/webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc @@ -140,7 +140,7 @@ class AudioProcessingTest : public AfterStreamingFixture { #if !defined(WEBRTC_IOS) && !defined(WEBRTC_ANDROID) -TEST_F(AudioProcessingTest, AgcIsOnByDefault) { +TEST_F(AudioProcessingTest, DISABLED_AgcIsOnByDefault) { bool agc_enabled = false; webrtc::AgcModes agc_mode = webrtc::kAgcAdaptiveAnalog; @@ -149,7 +149,7 @@ TEST_F(AudioProcessingTest, AgcIsOnByDefault) { EXPECT_EQ(webrtc::kAgcAdaptiveAnalog, agc_mode); } -TEST_F(AudioProcessingTest, CanEnableAgcWithAllModes) { +TEST_F(AudioProcessingTest, DISABLED_CanEnableAgcWithAllModes) { TryEnablingAgcWithMode(webrtc::kAgcAdaptiveDigital); TryEnablingAgcWithMode(webrtc::kAgcAdaptiveAnalog); TryEnablingAgcWithMode(webrtc::kAgcFixedDigital); @@ -248,7 +248,7 @@ TEST_F(AudioProcessingTest, CanSetAecmMode) { TryEnablingAecmWithMode(webrtc::kAecmSpeakerphone, false); } -TEST_F(AudioProcessingTest, RxAgcShouldBeOffByDefault) { +TEST_F(AudioProcessingTest, DISABLED_RxAgcShouldBeOffByDefault) { bool rx_agc_enabled = true; webrtc::AgcModes agc_mode = webrtc::kAgcDefault; @@ -257,12 +257,12 @@ TEST_F(AudioProcessingTest, RxAgcShouldBeOffByDefault) { EXPECT_EQ(webrtc::kAgcAdaptiveDigital, agc_mode); } -TEST_F(AudioProcessingTest, CanTurnOnDigitalRxAcg) { +TEST_F(AudioProcessingTest, DISABLED_CanTurnOnDigitalRxAcg) { TryEnablingRxAgcWithMode(webrtc::kAgcAdaptiveDigital); TryEnablingRxAgcWithMode(webrtc::kAgcFixedDigital); } -TEST_F(AudioProcessingTest, CannotTurnOnAdaptiveAnalogRxAgc) { +TEST_F(AudioProcessingTest, DISABLED_CannotTurnOnAdaptiveAnalogRxAgc) { EXPECT_EQ(-1, voe_apm_->SetRxAgcStatus( channel_, true, webrtc::kAgcAdaptiveAnalog)); }