From 42d65ce8d75005758e69c5f6a84684d2b3132e53 Mon Sep 17 00:00:00 2001 From: "solenberg@webrtc.org" Date: Fri, 1 Aug 2014 10:07:46 +0000 Subject: [PATCH] Fix memory leak in FakeSSLCertificate::GetChain(), discovered by Linux Memcheck build/try bots. TBR=hellner BUG= Review URL: https://webrtc-codereview.appspot.com/18969004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@6809 4adac7df-926f-26a2-2b94-8c16560cd09d --- talk/base/fakesslidentity.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/talk/base/fakesslidentity.h b/talk/base/fakesslidentity.h index fbe5e64842..5864dcc153 100644 --- a/talk/base/fakesslidentity.h +++ b/talk/base/fakesslidentity.h @@ -82,6 +82,7 @@ class FakeSSLCertificate : public talk_base::SSLCertificate { std::vector new_certs(certs_.size()); std::transform(certs_.begin(), certs_.end(), new_certs.begin(), DupCert); *chain = new SSLCertChain(new_certs); + std::for_each(new_certs.begin(), new_certs.end(), DeleteCert); return true; } @@ -89,6 +90,7 @@ class FakeSSLCertificate : public talk_base::SSLCertificate { static FakeSSLCertificate* DupCert(FakeSSLCertificate cert) { return cert.GetReference(); } + static void DeleteCert(SSLCertificate* cert) { delete cert; } std::string data_; std::vector certs_; std::string digest_algorithm_;