admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert of Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests. (patchset #1 id:1 of https://codereview.webrtc.org/2063313003/ )

Browse Source 
Reason for revert:
Reverting after experiment.  What seems to happen is that the thread can't be stopped when PostThreadMessage fails with this error code (or lack thereof).

Original issue's description:
> Attempt to figure out what the issue is on the Win10 FYI build bot in content_browsertests.
> Check for the case when PostThreadMessage returns false but GetLastError returns ERROR_SUCCESS.
>
> TBR=olka
> NOTRY=true
>
> Committed: https://crrev.com/e11041159d6e66fb25c2e045ad1558fc99d2d6cd
> Cr-Commit-Position: refs/heads/master@{#13143}

TBR=olka@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.webrtc.org/2067013003
Cr-Commit-Position: refs/heads/master@{#13147}
This commit is contained in:
tommi 2016-06-14 16:06:26 -07:00 committed by Commit bot
parent 17c3cddf9d
commit 42883f8b85
1 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/base/task_queue_win.cc
View File

@ -62,13 +62,7 @@ TaskQueue::TaskQueue(const char* queue_name)
TaskQueue::~TaskQueue() {
RTC_DCHECK(!IsCurrent());
while (!PostThreadMessage(thread_.GetThreadRef(), WM_QUIT, 0, 0)) {
DWORD last_error = ::GetLastError();
if (last_error == ERROR_SUCCESS) {
// TODO(tommi): Figure out what's going on on the Win10 build bot when
// we get this error.
break;
}
RTC_CHECK_EQ(static_cast<DWORD>(ERROR_NOT_ENOUGH_QUOTA), last_error);
RTC_CHECK_EQ(static_cast<DWORD>(ERROR_NOT_ENOUGH_QUOTA), ::GetLastError());
Sleep(1);
}
thread_.Stop();