admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix lint warnings in TaskQueueStdlib

Browse Source 
Bug: None
Change-Id: I4fd89dac39c0585793601d7adb5181a6ac15a64f
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/368460
Reviewed-by: Ilya Nikolaevskiy <ilnik@webrtc.org>
Commit-Queue: Björn Terelius <terelius@webrtc.org>
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#43415}
This commit is contained in:
Björn Terelius 2024-11-18 11:35:47 +01:00 committed by WebRTC LUCI CQ
parent 69cc695699
commit 3ffe94314a
2 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
rtc_base/task_queue_stdlib.cc
View File

@ -16,6 +16,7 @@
#include <map> #include <map>
#include <memory> #include <memory>
#include <queue> #include <queue>
#include <tuple>
#include <utility> #include <utility>
#include "absl/functional/any_invocable.h" #include "absl/functional/any_invocable.h"
@ -200,12 +201,12 @@ TaskQueueStdlib::NextTask TaskQueueStdlib::GetNextTask() {
return result; return result;
} }
if (delayed_queue_.size() > 0) { if (!delayed_queue_.empty()) {
auto delayed_entry = delayed_queue_.begin(); auto delayed_entry = delayed_queue_.begin();
const auto& delay_info = delayed_entry->first; const auto& delay_info = delayed_entry->first;
auto& delay_run = delayed_entry->second; auto& delay_run = delayed_entry->second;
if (tick_us >= delay_info.next_fire_at_us) { if (tick_us >= delay_info.next_fire_at_us) {
if (pending_queue_.size() > 0) { if (!pending_queue_.empty()) {
auto& entry = pending_queue_.front(); auto& entry = pending_queue_.front();
auto& entry_order = entry.first; auto& entry_order = entry.first;
auto& entry_run = entry.second; auto& entry_run = entry.second;
@ -225,7 +226,7 @@ TaskQueueStdlib::NextTask TaskQueueStdlib::GetNextTask() {
DivideRoundUp(delay_info.next_fire_at_us - tick_us, 1'000)); DivideRoundUp(delay_info.next_fire_at_us - tick_us, 1'000));
} }
if (pending_queue_.size() > 0) { if (!pending_queue_.empty()) {
auto& entry = pending_queue_.front(); auto& entry = pending_queue_.front();
result.run_task = std::move(entry.second); result.run_task = std::move(entry.second);
pending_queue_.pop(); pending_queue_.pop();

3
rtc_base/task_queue_stdlib_unittest.cc
View File

@ -10,6 +10,9 @@
#include "rtc_base/task_queue_stdlib.h" #include "rtc_base/task_queue_stdlib.h"
#include <memory>
#include <string>
#include "api/task_queue/task_queue_factory.h" #include "api/task_queue/task_queue_factory.h"
#include "api/task_queue/task_queue_test.h" #include "api/task_queue/task_queue_test.h"
#include "api/units/time_delta.h" #include "api/units/time_delta.h"