From 3f8f5554a0d5a73496f3f9df07fd14b4cee638c6 Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Wed, 22 Oct 2014 10:30:30 +0000 Subject: [PATCH] Disable TestVp8Impl.BaseUnitTest on MSan. MemorySanitizer uses generic (non-optimized) libvpx which is not bit exact. This may be a bug in upstream libvpx, but we're forced to disable it now as it blocks launching the MSan bot. R=stefan@webrtc.org TBR=marpan@webrtc.org BUG=3904 Review URL: https://webrtc-codereview.appspot.com/24089004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7491 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../video_coding/codecs/vp8/test/vp8_impl_unittest.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc index 3cc8bc330d..5e0bfc826a 100644 --- a/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc +++ b/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc @@ -192,7 +192,13 @@ class TestVp8Impl : public ::testing::Test { VideoCodec codec_inst_; }; +// Disabled on MemorySanitizer as it's breaking on generic libvpx. +// https://code.google.com/p/webrtc/issues/detail?id=3904 +#if defined(MEMORY_SANITIZER) +TEST_F(TestVp8Impl, DISABLED_BaseUnitTest) { +#else TEST_F(TestVp8Impl, DISABLED_ON_ANDROID(BaseUnitTest)) { +#endif // TODO(mikhal): Remove dependency. Move all test code here. EXPECT_EQ(WEBRTC_VIDEO_CODEC_OK, encoder_->Release()); UnitTest unittest;