From 3ed348707e93980fd74246f7a1dfab011f841087 Mon Sep 17 00:00:00 2001 From: asapersson Date: Tue, 10 Nov 2015 05:16:26 -0800 Subject: [PATCH] Remove field trial check for VP9. VP9 is put as second codec in supported codec list. BUG=chromium:500602 Review URL: https://codereview.webrtc.org/1432673002 Cr-Commit-Position: refs/heads/master@{#10577} --- talk/media/webrtc/webrtcvideoengine2.cc | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/talk/media/webrtc/webrtcvideoengine2.cc b/talk/media/webrtc/webrtcvideoengine2.cc index c0c9a8f6b0..0c19a4114e 100644 --- a/talk/media/webrtc/webrtcvideoengine2.cc +++ b/talk/media/webrtc/webrtcvideoengine2.cc @@ -152,9 +152,7 @@ bool CodecIsInternallySupported(const std::string& codec_name) { return true; } if (CodecNamesEq(codec_name, kVp9CodecName)) { - const std::string group_name = - webrtc::field_trial::FindFullName("WebRTC-SupportVP9"); - return group_name == "Enabled" || group_name == "EnabledByFlag"; + return true; } if (CodecNamesEq(codec_name, kH264CodecName)) { return webrtc::H264Encoder::IsSupported() && @@ -303,7 +301,8 @@ static void MergeFecConfig(const webrtc::FecConfig& other, // Returns true if the given codec is disallowed from doing simulcast. bool IsCodecBlacklistedForSimulcast(const std::string& codec_name) { - return CodecNamesEq(codec_name, kH264CodecName); + return CodecNamesEq(codec_name, kH264CodecName) || + CodecNamesEq(codec_name, kVp9CodecName); } // The selected thresholds for QVGA and VGA corresponded to a QP around 10. @@ -339,13 +338,13 @@ static const int kDefaultRtcpReceiverReportSsrc = 1; std::vector DefaultVideoCodecList() { std::vector codecs; + codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultVp8PlType, + kVp8CodecName)); if (CodecIsInternallySupported(kVp9CodecName)) { codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultVp9PlType, kVp9CodecName)); // TODO(andresp): Add rtx codec for vp9 and verify it works. } - codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultVp8PlType, - kVp8CodecName)); if (CodecIsInternallySupported(kH264CodecName)) { codecs.push_back(MakeVideoCodecWithDefaultFeedbackParams(kDefaultH264PlType, kH264CodecName));