From 3e95d3ef39c0e5e13d697dab9a8abea0e72feb4e Mon Sep 17 00:00:00 2001 From: Peter Thatcher Date: Mon, 18 May 2015 15:55:18 -0700 Subject: [PATCH] Don't log warning for unexpected STUN binding responses. It was too spammy in the log because we have many code paths that check for responses when it's not a problem that it's not an expected response. R=glaznev@webrtc.org Review URL: https://webrtc-codereview.appspot.com/47199004 Cr-Commit-Position: refs/heads/master@{#9212} --- webrtc/p2p/base/stunrequest.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/webrtc/p2p/base/stunrequest.cc b/webrtc/p2p/base/stunrequest.cc index e3f21df7b4..c5700c0466 100644 --- a/webrtc/p2p/base/stunrequest.cc +++ b/webrtc/p2p/base/stunrequest.cc @@ -78,8 +78,8 @@ void StunRequestManager::Clear() { bool StunRequestManager::CheckResponse(StunMessage* msg) { RequestMap::iterator iter = requests_.find(msg->transaction_id()); if (iter == requests_.end()) { - LOG(LS_WARNING) << "Ignoring STUN response for unknown request " - << rtc::hex_encode(msg->transaction_id()); + // TODO(pthatcher): Log unknown responses without being too spammy + // in the logs. return false; } @@ -111,8 +111,8 @@ bool StunRequestManager::CheckResponse(const char* data, size_t size) { RequestMap::iterator iter = requests_.find(id); if (iter == requests_.end()) { - LOG(LS_WARNING) << "Ignoring STUN response for unknown request " - << rtc::hex_encode(id); + // TODO(pthatcher): Log unknown responses without being too spammy + // in the logs. return false; }