From 3def74b1b82c5bbc14a37f4922e60d6f846e84e6 Mon Sep 17 00:00:00 2001 From: henrika Date: Fri, 6 Oct 2017 11:23:30 +0200 Subject: [PATCH] Disables AudioDeviceTest.RunPlayoutAndRecordingInFullDuplex on Android TBR=henrik.lundin Bug: webrtc:7744 Change-Id: I0ebfd3016d9d6b815d5b1801e8481363da11af54 Reviewed-on: https://webrtc-review.googlesource.com/7200 Reviewed-by: Henrik Andreassson Commit-Queue: Henrik Andreassson Cr-Commit-Position: refs/heads/master@{#20179} --- modules/audio_device/android/audio_device_unittest.cc | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/modules/audio_device/android/audio_device_unittest.cc b/modules/audio_device/android/audio_device_unittest.cc index a354a7cc33..4a9262b044 100644 --- a/modules/audio_device/android/audio_device_unittest.cc +++ b/modules/audio_device/android/audio_device_unittest.cc @@ -960,7 +960,13 @@ TEST_F(AudioDeviceTest, RunPlayoutWithFileAsSource) { // recording side and decreased by the playout side. // TODO(henrika): tune the final test parameters after running tests on several // different devices. -TEST_F(AudioDeviceTest, RunPlayoutAndRecordingInFullDuplex) { +// Disabling this test on bots since it is difficult to come up with a robust +// test condition that all worked as intended. The main issue is that, when +// swarming is used, an initial latency can be built up when the both sides +// starts at different times. Hence, the test can fail even if audio works +// as intended. Keeping the test so it can be enabled manually. +// http://bugs.webrtc.org/7744 +TEST_F(AudioDeviceTest, DISABLED_RunPlayoutAndRecordingInFullDuplex) { EXPECT_EQ(record_channels(), playout_channels()); EXPECT_EQ(record_sample_rate(), playout_sample_rate()); NiceMock mock(kPlayout | kRecording);