From 3d22114f1c675d7d2c5c8e47a3f547f979a33374 Mon Sep 17 00:00:00 2001 From: Artem Titarenko Date: Thu, 31 Jan 2019 12:33:56 +0000 Subject: [PATCH] Revert "Make internal.*.webrtc iOS bots dimensions depend on bot_id and pool only" This reverts commit 9a27c2fc7a2eb068eb06fad2e991039e2fceb960. Reason for revert: device_type and os version is mandatory for correct step naming Original change's description: > Make internal.*.webrtc iOS bots dimensions depend on bot_id and pool only > > Bug: webrtc:10047 > Change-Id: I48bcc15721859062c73c7e5fbae7a2fd65713adc > Reviewed-on: https://webrtc-review.googlesource.com/c/120615 > Reviewed-by: Oleh Prypin > Commit-Queue: Artem Titarenko > Cr-Commit-Position: refs/heads/master@{#26485} TBR=oprypin@webrtc.org,artit@webrtc.org Change-Id: I511eec8e8c24e82881be06ca0ca7b7038971db94 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: webrtc:10047 Reviewed-on: https://webrtc-review.googlesource.com/c/120802 Reviewed-by: Artem Titarenko Commit-Queue: Artem Titarenko Cr-Commit-Position: refs/heads/master@{#26492} --- .../ios/internal.client.webrtc/iOS64_Perf.json | 4 ++-- .../internal.tryserver.webrtc/ios_arm64_perf.json | 6 +++--- tools_webrtc/ios/tests/perf_tests.json | 4 +++- tools_webrtc/ios/tests/perf_trybot_tests.json | 12 ++++++++++++ 4 files changed, 20 insertions(+), 6 deletions(-) create mode 100644 tools_webrtc/ios/tests/perf_trybot_tests.json diff --git a/tools_webrtc/ios/internal.client.webrtc/iOS64_Perf.json b/tools_webrtc/ios/internal.client.webrtc/iOS64_Perf.json index a0d97acd62..14cb1144f8 100644 --- a/tools_webrtc/ios/internal.client.webrtc/iOS64_Perf.json +++ b/tools_webrtc/ios/internal.client.webrtc/iOS64_Perf.json @@ -19,8 +19,8 @@ "tests": [ { "include": "perf_tests.json", - "bot id": "build15-a7", - "pool": "WebRTC", + "device type": "iPhone 7", + "os": "11.0.3", "max runtime seconds": 7200 } ] diff --git a/tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64_perf.json b/tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64_perf.json index e1f5632d7a..e7b974355f 100644 --- a/tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64_perf.json +++ b/tools_webrtc/ios/internal.tryserver.webrtc/ios_arm64_perf.json @@ -18,9 +18,9 @@ "bucket": "chromium-webrtc", "tests": [ { - "include": "perf_tests.json", - "bot id": "build16-a7", - "pool": "WebRTC", + "include": "perf_trybot_tests.json", + "device type": "iPhone 7", + "os": "11.0.3", "max runtime seconds": 7200 } ] diff --git a/tools_webrtc/ios/tests/perf_tests.json b/tools_webrtc/ios/tests/perf_tests.json index 05a34be357..a249b98445 100644 --- a/tools_webrtc/ios/tests/perf_tests.json +++ b/tools_webrtc/ios/tests/perf_tests.json @@ -4,7 +4,9 @@ "app": "webrtc_perf_tests", "test args": [ "--save_chartjson_result" - ] + ], + "bot id": "build15-a7", + "pool": "WebRTC" } ] } diff --git a/tools_webrtc/ios/tests/perf_trybot_tests.json b/tools_webrtc/ios/tests/perf_trybot_tests.json new file mode 100644 index 0000000000..02a792ad2a --- /dev/null +++ b/tools_webrtc/ios/tests/perf_trybot_tests.json @@ -0,0 +1,12 @@ +{ + "tests": [ + { + "app": "webrtc_perf_tests", + "test args": [ + "--save_chartjson_result" + ], + "bot id": "build16-a7", + "pool": "WebRTC" + } + ] +}