From 3c5a1bf8f32a75a67d09262032f035af44500d91 Mon Sep 17 00:00:00 2001 From: Tommi Date: Mon, 17 Oct 2022 10:39:01 +0200 Subject: [PATCH] [TurnPort] Update CreateOrRefreshEntry function, step 2. This removes the deprecated method in favor of the new one introduced in https://webrtc-review.googlesource.com/c/src/+/279440 Bug: chromium:1374310 Change-Id: I662d5cad9a48d18d9425e4d2754a966df68f7056 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/279441 Commit-Queue: Tomas Gunnarsson Reviewed-by: Jonas Oreland Cr-Commit-Position: refs/heads/main@{#38411} --- p2p/base/turn_port.cc | 5 ----- p2p/base/turn_port.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/p2p/base/turn_port.cc b/p2p/base/turn_port.cc index 3b060f73e4..bb3e0786b1 100644 --- a/p2p/base/turn_port.cc +++ b/p2p/base/turn_port.cc @@ -1207,11 +1207,6 @@ bool TurnPort::EntryExists(TurnEntry* e) { return absl::c_linear_search(entries_, e); } -bool TurnPort::CreateOrRefreshEntry(const rtc::SocketAddress& addr, - int channel_number) { - return CreateOrRefreshEntry(addr, channel_number, ""); -} - bool TurnPort::CreateOrRefreshEntry(Connection* conn, int channel_number) { return CreateOrRefreshEntry(conn->remote_candidate().address(), channel_number, diff --git a/p2p/base/turn_port.h b/p2p/base/turn_port.h index 50d78ced61..640833c17b 100644 --- a/p2p/base/turn_port.h +++ b/p2p/base/turn_port.h @@ -231,9 +231,6 @@ class TurnPort : public Port { // NOTE: This method needs to be accessible for StunPort // return true if entry was created (i.e channel_number consumed). - // TODO(tommi): Remove this method in favor of the one that accepts a - // `Connection` pointer. - bool CreateOrRefreshEntry(const rtc::SocketAddress& addr, int channel_number); bool CreateOrRefreshEntry(Connection* conn, int channel_number); bool CreateOrRefreshEntry(const rtc::SocketAddress& addr,