admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reduce logging for PC supported codecs in PC level tests

Browse Source 
Bug: None
Change-Id: I78db2d129c277c11375d8903d3127944ff832fec
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/214760
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#33669}
This commit is contained in:
Artem Titov 2021-04-09 12:17:53 +02:00 committed by Commit Bot
parent 64099bcbe7
commit 3c31ee0793
1 changed files with 19 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
test/pc/e2e/sdp/sdp_changer.cc
View File

@ -34,6 +34,23 @@ std::string CodecRequiredParamsToString(
return out.str();
}
std::string SupportedCodecsToString(
rtc::ArrayView<const RtpCodecCapability> supported_codecs) {
rtc::StringBuilder out;
for (const auto& codec : supported_codecs) {
out << codec.name;
if (!codec.parameters.empty()) {
out << "(";
for (const auto& param : codec.parameters) {
out << param.first << "=" << param.second << ";";
}
out << ")";
}
out << "; ";
}
return out.str();
}
} // namespace
std::vector<RtpCodecCapability> FilterVideoCodecCapabilities(
@ -42,16 +59,6 @@ std::vector<RtpCodecCapability> FilterVideoCodecCapabilities(
bool use_ulpfec,
bool use_flexfec,
rtc::ArrayView<const RtpCodecCapability> supported_codecs) {
RTC_LOG(INFO) << "Peer connection support these codecs:";
for (const auto& codec : supported_codecs) {
RTC_LOG(INFO) << "Codec: " << codec.name;
if (!codec.parameters.empty()) {
RTC_LOG(INFO) << "Params:";
for (const auto& param : codec.parameters) {
RTC_LOG(INFO) << " " << param.first << "=" << param.second;
}
}
}
std::vector<RtpCodecCapability> output_codecs;
// Find requested codecs among supported and add them to output in the order
// they were requested.
@ -80,7 +87,8 @@ std::vector<RtpCodecCapability> FilterVideoCodecCapabilities(
RTC_CHECK_GT(output_codecs.size(), size_before)
<< "Codec with name=" << codec_request.name << " and params {"
<< CodecRequiredParamsToString(codec_request.required_params)
<< "} is unsupported for this peer connection";
<< "} is unsupported for this peer connection. Supported codecs are: "
<< SupportedCodecsToString(supported_codecs);
}
// Add required FEC and RTX codecs to output.