admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Create default video factories directly instead of through legacy public helpers

Browse Source 
Bug: webrtc:13573
Change-Id: If8ab26dc45cce2dac17572772bb21806a54ed3e3
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299660
Reviewed-by: Philip Eliasson <philipel@webrtc.org>
Auto-Submit: Danil Chapovalov <danilchap@webrtc.org>
Reviewed-by: Per Kjellander <perkj@webrtc.org>
Commit-Queue: Per Kjellander <perkj@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39729}
This commit is contained in:
Danil Chapovalov 2023-03-31 13:15:05 +02:00 committed by WebRTC LUCI CQ
parent 2bac7ef244
commit 3beacb7a87
2 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
media/BUILD.gn
View File

@ -553,12 +553,11 @@ rtc_library("rtc_media_engine_defaults") {
]
deps = [
":rtc_audio_video",
":rtc_internal_video_codecs",
"../api/audio_codecs:builtin_audio_decoder_factory",
"../api/audio_codecs:builtin_audio_encoder_factory",
"../api/task_queue:default_task_queue_factory",
"../api/video:builtin_video_bitrate_allocator_factory",
"../api/video_codecs:builtin_video_decoder_factory",
"../api/video_codecs:builtin_video_encoder_factory",
"../modules/audio_processing:api",
"../rtc_base:checks",
"../rtc_base/system:rtc_export",

10
media/engine/webrtc_media_engine_defaults.cc
View File

@ -9,12 +9,14 @@
*/
#include "media/engine/webrtc_media_engine_defaults.h"
#include <memory>
#include "api/audio_codecs/builtin_audio_decoder_factory.h"
#include "api/audio_codecs/builtin_audio_encoder_factory.h"
#include "api/task_queue/default_task_queue_factory.h"
#include "api/video/builtin_video_bitrate_allocator_factory.h"
#include "api/video_codecs/builtin_video_decoder_factory.h"
#include "api/video_codecs/builtin_video_encoder_factory.h"
#include "media/engine/internal_decoder_factory.h"
#include "media/engine/internal_encoder_factory.h"
#include "modules/audio_processing/include/audio_processing.h"
#include "rtc_base/checks.h"
@ -35,9 +37,9 @@ void SetMediaEngineDefaults(cricket::MediaEngineDependencies* deps) {
deps->audio_processing = AudioProcessingBuilder().Create();
if (deps->video_encoder_factory == nullptr)
deps->video_encoder_factory = CreateBuiltinVideoEncoderFactory();
deps->video_encoder_factory = std::make_unique<InternalEncoderFactory>();
if (deps->video_decoder_factory == nullptr)
deps->video_decoder_factory = CreateBuiltinVideoDecoderFactory();
deps->video_decoder_factory = std::make_unique<InternalDecoderFactory>();
}
} // namespace webrtc