admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "Add 'is_chrome_branded' guard to the default of 'rtc_use_h264'"

Browse Source 
This reverts commit d3070f43b19f503246be4ebad425d87568a71ce0.

Reason for revert: Need to re-enable h264 tests.

Original change's description:
> Add 'is_chrome_branded' guard to the default of 'rtc_use_h264'
> 
> This doesn't change behavior at the moment because Chromium's
> 'proprietary_codecs' is already conditional on 'is_chrome_branded'
> but this guards WebRTC's default from upstream changes like
> https://chromium-review.googlesource.com/c/chromium/src/+/835010/6/build/config/features.gni
> 
> TBR=phoglund@webrtc.org
> 
> Bug: webrtc:8675
> Change-Id: Ic2ae311b5fc70a4d1ac1aefe4cc27574e4fcee40
> Reviewed-on: https://webrtc-review.googlesource.com/36321
> Commit-Queue: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
> Reviewed-by: Henrik Boström <hbos@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#21452}

TBR=phoglund@webrtc.org,oprypin@webrtc.org,hbos@webrtc.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: webrtc:8675
Change-Id: I97e5b25fb638e9d4731ac9610f9f6009a3789578
Reviewed-on: https://webrtc-review.googlesource.com/62380
Reviewed-by: Patrik Höglund <phoglund@webrtc.org>
Reviewed-by: Oleh Prypin <oprypin@webrtc.org>
Commit-Queue: Patrik Höglund <phoglund@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#22476}
This commit is contained in:
Patrik Höglund 2018-03-16 12:36:26 +00:00 committed by Commit Bot
parent 35468356d6
commit 3bb1194fff
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
webrtc.gni
View File

@ -121,8 +121,7 @@ declare_args() {
# also: |rtc_initialize_ffmpeg|. # also: |rtc_initialize_ffmpeg|.
# CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING. # CHECK THE OPENH264, FFMPEG AND H.264 LICENSES/PATENTS BEFORE BUILDING.
# http://www.openh264.org, https://www.ffmpeg.org/ # http://www.openh264.org, https://www.ffmpeg.org/
rtc_use_h264 = rtc_use_h264 = proprietary_codecs && !is_android && !is_ios
is_chrome_branded && proprietary_codecs && !is_android && !is_ios
# By default, use normal platform audio support or dummy audio, but don't # By default, use normal platform audio support or dummy audio, but don't
# use file-based audio playout and record. # use file-based audio playout and record.