admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Reland "Make webrtc_fuzzer_test use //:common_config."

Browse Source 
This is a reland of 9e09831767995531ae1c2804e1c15fa2be4053f2

The field "additional_configs" needs to be used to set "configs"
for the "fuzzer_test" GN template. See
https://source.chromium.org/chromium/chromium/src/+/main:testing/libfuzzer/fuzzer_test.gni;l=18;drc=825f86aa594207bfc50f87495544b48014814c9d.

Original change's description:
> Make webrtc_fuzzer_test use //:common_config.
>
> Before this CL, the GN template webrtc_fuzzer_test was using a build
> config that was different from the one used by other WebRTC's targets.
>
> We discovered this in [1] where we detected that RTC_DCHECK_IS_ON had
> different values across translation units (1 everywhere and 0 in the
> one of the .cc file owned by the webrtc_fuzzer_test).
>
> This was because webrtc_fuzzer_test was not including the default
> config //:common_config in its "configs".
>
> [1] - https://webrtc-review.googlesource.com/c/src/+/226465
>
> Bug: None
> Change-Id: I5635d90281769c23c5d86ebc8cb494da029c2e85
> Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226540
> Reviewed-by: Andrey Logvin <landrey@webrtc.org>
> Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
> Cr-Commit-Position: refs/heads/master@{#34509}

Bug: None
Change-Id: I56e2a7ea811a94762e09953acf3d33d3f46b1d24
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/226542
Reviewed-by: Andrey Logvin <landrey@webrtc.org>
Commit-Queue: Mirko Bonadei <mbonadei@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#34511}
This commit is contained in:
Mirko Bonadei 2021-07-20 10:37:07 +02:00 committed by WebRTC LUCI CQ
parent 022567dc9c
commit 3b35fbcb66
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/fuzzers/BUILD.gn
View File

@ -42,6 +42,7 @@ rtc_library("fuzz_data_helper") {
}
set_defaults("webrtc_fuzzer_test") {
configs = rtc_add_configs
absl_deps = []
}
@ -52,6 +53,7 @@ template("webrtc_fuzzer_test") {
":fuzz_data_helper",
":webrtc_fuzzer_main",
]
additional_configs = configs
# If absl_deps is [], no action is needed. If not [], then it needs to be
# converted to //third_party/abseil-cpp:absl when build_with_chromium=true