From 3a9731ff2f871bcc798ce9760fa51d81cfd5e755 Mon Sep 17 00:00:00 2001 From: Alex Loiko Date: Fri, 21 Sep 2018 15:41:27 +0200 Subject: [PATCH] Bug in histogram metric reporting. A (actually several weeks) while ago, we noticed an error with the WebRTC.Audio.Agc2.EstimatedNoiseLevel histogram. It always reported the value 0. Here is why: The histogram bins go from 0 to 100. But the value logged is dBFS. It is always less than or equal to 0. This CL changes the bins. Bug: webrtc:7494 Change-Id: I45fd122e98f9396f9871bc965a708987bd1815f6 Reviewed-on: https://webrtc-review.googlesource.com/101340 Commit-Queue: Alex Loiko Reviewed-by: Sam Zackrisson Cr-Commit-Position: refs/heads/master@{#24800} --- modules/audio_processing/agc2/adaptive_digital_gain_applier.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/modules/audio_processing/agc2/adaptive_digital_gain_applier.cc b/modules/audio_processing/agc2/adaptive_digital_gain_applier.cc index f5342df829..9d791ae234 100644 --- a/modules/audio_processing/agc2/adaptive_digital_gain_applier.cc +++ b/modules/audio_processing/agc2/adaptive_digital_gain_applier.cc @@ -83,7 +83,7 @@ void AdaptiveDigitalGainApplier::Process( RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.Audio.Agc2.DigitalGainApplied", last_gain_db_, 0, kMaxGainDb, kMaxGainDb + 1); RTC_HISTOGRAM_COUNTS_LINEAR("WebRTC.Audio.Agc2.EstimatedNoiseLevel", - input_noise_level_dbfs, 0, 100, 101); + input_noise_level_dbfs, -100, 0, 101); } input_level_dbfs = std::min(input_level_dbfs, 0.f);