From 3970fa85b3dd3a34bf7c6ad22b002d512a29382d Mon Sep 17 00:00:00 2001 From: Danil Chapovalov Date: Thu, 16 Feb 2023 15:36:32 +0100 Subject: [PATCH] Delete few stale TODOs where no action is planned encrypted_video_payload already allocates enough bytes - first SetSize query such size from the frame_encryptor_ Minimizing VP9 when generic descriptor is used might be harmful in multi-participant scenario where frame needs to be send to a participant without generic descriptor support and thus require complicated restoration of the VP9 specific descriptor. No-Try: true Bug: None Change-Id: I5f2c32c2c9ae745794dfaaa4aec4c5898dff78f7 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/293820 Commit-Queue: Danil Chapovalov Reviewed-by: Emil Lundmark Cr-Commit-Position: refs/heads/main@{#39327} --- modules/rtp_rtcp/source/rtp_sender_video.cc | 2 -- 1 file changed, 2 deletions(-) diff --git a/modules/rtp_rtcp/source/rtp_sender_video.cc b/modules/rtp_rtcp/source/rtp_sender_video.cc index e1f1697047..92cebfd422 100644 --- a/modules/rtp_rtcp/source/rtp_sender_video.cc +++ b/modules/rtp_rtcp/source/rtp_sender_video.cc @@ -71,7 +71,6 @@ bool MinimizeDescriptor(RTPVideoHeader* video_header) { vp8->nonReference = non_reference; return true; } - // TODO(danilchap): Reduce vp9 codec specific descriptor too. return false; } @@ -624,7 +623,6 @@ bool RTPSenderVideo::SendVideo( MinimizeDescriptor(&video_header); } - // TODO(benwright@webrtc.org) - Allocate enough to always encrypt inline. rtc::Buffer encrypted_video_payload; if (frame_encryptor_ != nullptr) { const size_t max_ciphertext_size =