From 38e6c66f4aa8af6bd342107e24cb699a0b353d2c Mon Sep 17 00:00:00 2001 From: Amit Hilbuch Date: Fri, 8 Mar 2019 16:17:21 -0800 Subject: [PATCH] CNAME is missing in simulcast layers. CNAME is only set on the first simulcast layer. It should be set on all of the layers. Bug: webrtc:10383 Change-Id: Iea345a100769f45d09078adb93e51b7702326492 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/126541 Reviewed-by: Steve Anton Reviewed-by: Niels Moller Commit-Queue: Amit Hilbuch Cr-Commit-Position: refs/heads/master@{#27134} --- call/rtp_video_sender.cc | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/call/rtp_video_sender.cc b/call/rtp_video_sender.cc index 7b7f350e02..fb7b613aef 100644 --- a/call/rtp_video_sender.cc +++ b/call/rtp_video_sender.cc @@ -301,10 +301,9 @@ RtpVideoSender::RtpVideoSender( } } - // TODO(pbos): Should we set CNAME on all RTP modules? - rtp_streams_.front().rtp_rtcp->SetCNAME(rtp_config.c_name.c_str()); - for (const RtpStreamSender& stream : rtp_streams_) { + // Simulcast has one module for each layer. Set the CNAME on all modules. + stream.rtp_rtcp->SetCNAME(rtp_config.c_name.c_str()); stream.rtp_rtcp->RegisterRtcpStatisticsCallback(observers.rtcp_stats); stream.rtp_rtcp->RegisterSendChannelRtpStatisticsCallback( observers.rtp_stats);