From 38ce7d03d83ec64c5394d425865803bf0894625f Mon Sep 17 00:00:00 2001 From: "pbos@webrtc.org" Date: Wed, 16 Jul 2014 08:01:38 +0000 Subject: [PATCH] Implement unittest for SetSendCodecsChangesExistingStreams. BUG=1788 R=pbos@webrtc.org, wu@webrtc.org Review URL: https://webrtc-codereview.appspot.com/19869004 Patch from Changbin Shao . git-svn-id: http://webrtc.googlecode.com/svn/trunk@6699 4adac7df-926f-26a2-2b94-8c16560cd09d --- .../webrtc/webrtcvideoengine2_unittest.cc | 20 ++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/talk/media/webrtc/webrtcvideoengine2_unittest.cc b/talk/media/webrtc/webrtcvideoengine2_unittest.cc index 85889b0c39..a58ed93c6b 100644 --- a/talk/media/webrtc/webrtcvideoengine2_unittest.cc +++ b/talk/media/webrtc/webrtcvideoengine2_unittest.cc @@ -1050,9 +1050,23 @@ TEST_F(WebRtcVideoChannel2Test, SetSendCodecsWithoutFecDisablesFec) { << "SetSendCodec without FEC should disable current FEC."; } -TEST_F(WebRtcVideoChannel2Test, DISABLED_SetSendCodecsChangesExistingStreams) { - FAIL(); // TODO(pbos): Implement, make sure that it's changing running - // streams. Should it? +TEST_F(WebRtcVideoChannel2Test, SetSendCodecsChangesExistingStreams) { + std::vector codecs; + codecs.push_back(kVp8Codec720p); + ASSERT_TRUE(channel_->SetSendCodecs(codecs)); + + std::vector streams = + AddSendStream()->GetVideoStreams(); + EXPECT_EQ(kVp8Codec720p.width, streams[0].width); + EXPECT_EQ(kVp8Codec720p.height, streams[0].height); + + codecs.clear(); + codecs.push_back(kVp8Codec360p); + ASSERT_TRUE(channel_->SetSendCodecs(codecs)); + streams = fake_channel_->GetFakeCall()->GetVideoSendStreams()[0] + ->GetVideoStreams(); + EXPECT_EQ(kVp8Codec360p.width, streams[0].width); + EXPECT_EQ(kVp8Codec360p.height, streams[0].height); } TEST_F(WebRtcVideoChannel2Test,