From 388e4e9d96f0e587a008111c612dd53339e3dfb2 Mon Sep 17 00:00:00 2001 From: Jonas Olsson Date: Fri, 16 Nov 2018 15:57:49 +0100 Subject: [PATCH] Make RTC_LOG_FILE_LINE use its parameters Our macros always pass __FILE__ and __LINE__ as parameters, so the impact was limited. However, doing the correct thing is obviously preferable to doing the wrong thing, so let's fix it. Bug: webrtc:10003 Change-Id: Id2529c4bd8c7e90a8f0ac3ffa713dbe305ba66d8 Reviewed-on: https://webrtc-review.googlesource.com/c/111244 Reviewed-by: Karl Wiberg Commit-Queue: Jonas Olsson Cr-Commit-Position: refs/heads/master@{#25712} --- rtc_base/logging.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/rtc_base/logging.h b/rtc_base/logging.h index c15c37af0a..c7d083e42d 100644 --- a/rtc_base/logging.h +++ b/rtc_base/logging.h @@ -519,10 +519,10 @@ class LogMessage { ? static_cast(0) \ : rtc::webrtc_logging_impl::LogMessageVoidify()& -#define RTC_LOG_FILE_LINE(sev, file, line) \ - rtc::webrtc_logging_impl::LogCall() & \ - rtc::webrtc_logging_impl::LogStreamer<>() \ - << rtc::webrtc_logging_impl::LogMetadata(__FILE__, __LINE__, sev) +#define RTC_LOG_FILE_LINE(sev, file, line) \ + rtc::webrtc_logging_impl::LogCall() & \ + rtc::webrtc_logging_impl::LogStreamer<>() \ + << rtc::webrtc_logging_impl::LogMetadata(file, line, sev) #define RTC_LOG(sev) RTC_LOG_FILE_LINE(rtc::sev, __FILE__, __LINE__)