From 3828c30b0638ff82f54b2b5eba64310d065dc767 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Niels=20M=C3=B6ller?= Date: Fri, 3 Jan 2020 10:28:47 +0100 Subject: [PATCH] Delete unused member BasicPortAllocator::allow_tcp_listen_ There's a similar member in the base class, PortAllocator, which appears to be in use. Bug: None Change-Id: Ie82801a7d0ae62f1e2758b6f434485bd5f78e8ba Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/164520 Reviewed-by: Harald Alvestrand Commit-Queue: Niels Moller Cr-Commit-Position: refs/heads/master@{#30145} --- p2p/client/basic_port_allocator.cc | 7 ------- p2p/client/basic_port_allocator.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/p2p/client/basic_port_allocator.cc b/p2p/client/basic_port_allocator.cc index 527410a0f0..bd25ab50ce 100644 --- a/p2p/client/basic_port_allocator.cc +++ b/p2p/client/basic_port_allocator.cc @@ -163,7 +163,6 @@ BasicPortAllocator::BasicPortAllocator( RTC_DCHECK(socket_factory_ != nullptr); SetConfiguration(ServerAddresses(), std::vector(), 0, webrtc::NO_PRUNE, customizer); - Construct(); } BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager) @@ -171,7 +170,6 @@ BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager) InitRelayPortFactory(nullptr); RTC_DCHECK(relay_port_factory_ != nullptr); RTC_DCHECK(network_manager_ != nullptr); - Construct(); } BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager, @@ -188,11 +186,6 @@ BasicPortAllocator::BasicPortAllocator(rtc::NetworkManager* network_manager, RTC_DCHECK(relay_port_factory_ != nullptr); SetConfiguration(stun_servers, std::vector(), 0, webrtc::NO_PRUNE, nullptr); - Construct(); -} - -void BasicPortAllocator::Construct() { - allow_tcp_listen_ = true; } void BasicPortAllocator::OnIceRegathering(PortAllocatorSession* session, diff --git a/p2p/client/basic_port_allocator.h b/p2p/client/basic_port_allocator.h index ab47ce1030..2af249341b 100644 --- a/p2p/client/basic_port_allocator.h +++ b/p2p/client/basic_port_allocator.h @@ -77,8 +77,6 @@ class RTC_EXPORT BasicPortAllocator : public PortAllocator { } private: - void Construct(); - void OnIceRegathering(PortAllocatorSession* session, IceRegatheringReason reason); @@ -89,7 +87,6 @@ class RTC_EXPORT BasicPortAllocator : public PortAllocator { rtc::NetworkManager* network_manager_; rtc::PacketSocketFactory* socket_factory_; - bool allow_tcp_listen_; int network_ignore_mask_ = rtc::kDefaultNetworkIgnoreMask; // This is the factory being used.