From 372cf8b8244e3b164a5eb8beab03391a3394edd8 Mon Sep 17 00:00:00 2001 From: Florent Castelli Date: Mon, 9 Jan 2023 15:48:28 +0100 Subject: [PATCH] Prevent rtc_base:log_sinks from being defined in Chromium This target belongs only to WebRTC and shouldn't be defined there. Bug: webrtc:9838 Change-Id: Id44573ed4649170820a5a61b68d6077784da8549 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/290722 Reviewed-by: Jeremy Leconte Reviewed-by: Jeremy Leconte Commit-Queue: Florent Castelli Cr-Commit-Position: refs/heads/main@{#39041} --- rtc_base/BUILD.gn | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/rtc_base/BUILD.gn b/rtc_base/BUILD.gn index 3f848d5753..3578fb81fc 100644 --- a/rtc_base/BUILD.gn +++ b/rtc_base/BUILD.gn @@ -1315,17 +1315,19 @@ if (is_win) { } } -rtc_library("log_sinks") { - sources = [ - "log_sinks.cc", - "log_sinks.h", - ] - deps = [ - ":checks", - ":file_rotating_stream", - ":logging", - ] - absl_deps = [ "//third_party/abseil-cpp/absl/strings" ] +if (!build_with_chromium) { + rtc_library("log_sinks") { + sources = [ + "log_sinks.cc", + "log_sinks.h", + ] + deps = [ + ":checks", + ":file_rotating_stream", + ":logging", + ] + absl_deps = [ "//third_party/abseil-cpp/absl/strings" ] + } } rtc_library("network") {