admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove logging of metrics no longer relevant for AEC2 usage (UMA).

Browse Source 
The acoustic echo canceler AEC2 is being deprecated. The routing for reporting these metrics as UMA stats has outlived the metrics'usefulness.

Bug: webrtc:10563
Change-Id: Ib96693dfc43e25a0cfecad7d5d2043116ca7e6b5
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/133573
Reviewed-by: Per Åhgren <peah@webrtc.org>
Commit-Queue: Sam Zackrisson <saza@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#27699}
This commit is contained in:
Sam Zackrisson 2019-04-18 13:54:45 +02:00 committed by Commit Bot
parent 26bf7c4682
commit 37242cbc41
1 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
modules/audio_processing/aec/aec_core.cc
View File

@ -36,34 +36,6 @@ extern "C" {
#include "system_wrappers/include/metrics.h"
namespace webrtc {
namespace {
enum class DelaySource {
kSystemDelay, // The delay values come from the OS.
kDelayAgnostic, // The delay values come from the DA-AEC.
};
constexpr int kMinDelayLogValue = -200;
constexpr int kMaxDelayLogValue = 200;
constexpr int kNumDelayLogBuckets = 100;
void MaybeLogDelayAdjustment(int moved_ms, DelaySource source) {
if (moved_ms == 0)
return;
switch (source) {
case DelaySource::kSystemDelay:
RTC_HISTOGRAM_COUNTS("WebRTC.Audio.AecDelayAdjustmentMsSystemValue",
moved_ms, kMinDelayLogValue, kMaxDelayLogValue,
kNumDelayLogBuckets);
return;
case DelaySource::kDelayAgnostic:
RTC_HISTOGRAM_COUNTS("WebRTC.Audio.AecDelayAdjustmentMsAgnosticValue",
moved_ms, kMinDelayLogValue, kMaxDelayLogValue,
kNumDelayLogBuckets);
return;
}
}
} // namespace
// Buffer size (samples)
static const size_t kBufferSizeBlocks = 250; // 1 second of audio in 16 kHz.
@ -1864,15 +1836,11 @@ void WebRtcAec_ProcessFrames(AecCore* aec,
// rounding, like -16.
int move_elements = (aec->knownDelay - knownDelay - 32) / PART_LEN;
int moved_elements = aec->farend_block_buffer_.AdjustSize(move_elements);
MaybeLogDelayAdjustment(moved_elements * (aec->sampFreq == 8000 ? 8 : 4),
DelaySource::kSystemDelay);
aec->knownDelay -= moved_elements * PART_LEN;
} else {
// 2 b) Apply signal based delay correction.
int move_elements = SignalBasedDelayCorrection(aec);
int moved_elements = aec->farend_block_buffer_.AdjustSize(move_elements);
MaybeLogDelayAdjustment(moved_elements * (aec->sampFreq == 8000 ? 8 : 4),
DelaySource::kDelayAgnostic);
int far_near_buffer_diff =
aec->farend_block_buffer_.Size() -
(aec->nearend_buffer_size + FRAME_LEN) / PART_LEN;