From 36b0c1afae15e6cb47971ba81d1a8cf670045cca Mon Sep 17 00:00:00 2001 From: "henrike@webrtc.org" Date: Wed, 1 Oct 2014 14:40:58 +0000 Subject: [PATCH] Adds PRESUBMIT.py dispensation for depending on rtc_base. Dispensation for: a few test suites, desktop capture and libjingle. BUG=N/A R=kjellander@webrtc.org Review URL: https://webrtc-codereview.appspot.com/31549004 git-svn-id: http://webrtc.googlecode.com/svn/trunk@7356 4adac7df-926f-26a2-2b94-8c16560cd09d --- PRESUBMIT.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 2cefb3613a..b949951d21 100755 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -100,6 +100,17 @@ def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api): pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'") violating_files = [] for f in gyp_files: + gyp_exceptions = ( + 'base_tests.gyp', + 'desktop_capture.gypi', + 'libjingle.gyp', + 'libjingle_tests.gyp' + 'sound.gyp', + 'webrtc_test_common.gyp', + 'webrtc_tests.gypi', + ) + if f.LocalPath().endswith(gyp_exceptions): + continue contents = input_api.ReadFile(f) if pattern.search(contents): violating_files.append(f)