From 36b096c38ee846143ea7acbe82b5cdf27e0388f9 Mon Sep 17 00:00:00 2001 From: Karl Wiberg Date: Thu, 19 Apr 2018 14:07:25 +0200 Subject: [PATCH] Ignore overflowing left shift It's audio data, not an index or anything like that, so the most an overflow can do is make it sound worse. Bug: chromium:834531 Change-Id: Icb39c1bb011219c1a6fe67bc582390daa2693379 Reviewed-on: https://webrtc-review.googlesource.com/71160 Reviewed-by: Henrik Lundin Commit-Queue: Karl Wiberg Cr-Commit-Position: refs/heads/master@{#22947} --- modules/audio_coding/codecs/isac/fix/source/lattice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/modules/audio_coding/codecs/isac/fix/source/lattice.c b/modules/audio_coding/codecs/isac/fix/source/lattice.c index 1089549aa7..7bbf4e054a 100644 --- a/modules/audio_coding/codecs/isac/fix/source/lattice.c +++ b/modules/audio_coding/codecs/isac/fix/source/lattice.c @@ -279,8 +279,7 @@ void WebRtcIsacfix_NormLatticeFilterAr(size_t orderCoef, for (i=0;iQ26 + tmp32 = OverflowingLShiftS32(lat_inQ25[i + temp1], 1); // Q25->Q26 tmp32 = WEBRTC_SPL_MUL_16_32_RSFT16(inv_gain16, tmp32); //lat_in[]*inv_gain in (Q(18-sh)*Q26)>>16 = Q(28-sh) tmp32 = WEBRTC_SPL_SHIFT_W32(tmp32, -(28-sh)); // lat_in[]*inv_gain in Q0