From 35b41a29b3b039b348460922dbae33992fb88b75 Mon Sep 17 00:00:00 2001 From: asapersson Date: Mon, 19 Dec 2016 05:54:15 -0800 Subject: [PATCH] Reland of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2585183002/ ) Reason for revert: Still hitting NOTREACHED. Original issue's description: > Revert of Disabling NOTREACHED which we're hitting flakily in browser tests. (patchset #1 id:1 of https://codereview.webrtc.org/2477663002/ ) > > Reason for revert: > To see if the NOTREACHED is still hit. > > Original issue's description: > > Disabling NOTREACHED which we're hitting flakily in browser tests. > > > > I have no idea how bad it is that we're hitting this limit; I'm just > > doing this to stop the tests from flaking. > > > > BUG=webrtc:6484 > > > > Committed: https://crrev.com/6eaa55867b449df992752c1df540ec42f9d9b057 > > Cr-Commit-Position: refs/heads/master@{#14974} > > TBR=stefan@webrtc.org,phoglund@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:6484 > > Review-Url: https://codereview.webrtc.org/2585183002 > Cr-Commit-Position: refs/heads/master@{#15665} > Committed: https://chromium.googlesource.com/external/webrtc/+/9d7ea0920c2b0a6b6644c99abdf10f415422d563 TBR=stefan@webrtc.org,phoglund@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6484 Review-Url: https://codereview.webrtc.org/2585273002 Cr-Commit-Position: refs/heads/master@{#15676} --- .../modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc b/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc index 7ffbe20902..c5d2ed9e61 100644 --- a/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc +++ b/webrtc/modules/video_coding/codecs/vp9/vp9_frame_buffer_pool.cc @@ -73,7 +73,10 @@ Vp9FrameBufferPool::GetFrameBuffer(size_t min_size) { << allocated_buffers_.size() << " Vp9FrameBuffers have been " << "allocated by a Vp9FrameBufferPool (exceeding what is " << "considered reasonable, " << max_num_buffers_ << ")."; - RTC_NOTREACHED(); + + // TODO(phoglund): this limit is being hit in tests since Oct 5 2016. + // See https://bugs.chromium.org/p/webrtc/issues/detail?id=6484. + // RTC_NOTREACHED(); } } }