admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove VERBOSE logs in (android) audio device code.

Browse Source 
When playing out, for example, you'd see 3 lines for every call to
PlayoutDelay, which happens quite often (every sample?).

The ones around the Playout/Recording Warning/Error are only once a
second, but they don't seem to add anything. Same with
Process/TimeUntilNextProcess, which just log that the method is called.

BUG=

Review-Url: https://codereview.webrtc.org/2202243004
Cr-Commit-Position: refs/heads/master@{#13763}
This commit is contained in:
noahric 2016-08-15 13:41:17 -07:00 committed by Commit bot
parent 43ba317c75
commit 3473288296
2 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
webrtc/modules/audio_device/android/audio_device_template.h
View File

@ -216,7 +216,6 @@ class AudioDeviceTemplate : public AudioDeviceGeneric {
}
bool Recording() const override {
LOG(LS_VERBOSE) << __FUNCTION__;
return input_.Recording() ;
}
@ -421,7 +420,6 @@ class AudioDeviceTemplate : public AudioDeviceGeneric {
int32_t PlayoutDelay(uint16_t& delay_ms) const override {
// Best guess we can do is to use half of the estimated total delay.
delay_ms = audio_manager_->GetDelayEstimateInMilliseconds() / 2;
LOG(LS_VERBOSE) << __FUNCTION__ << " delay = " << delay_ms;
RTC_DCHECK_GT(delay_ms, 0);
return 0;
}
@ -440,22 +438,18 @@ class AudioDeviceTemplate : public AudioDeviceGeneric {
}
bool PlayoutWarning() const override {
LOG(LS_VERBOSE) << __FUNCTION__;
return false;
}
bool PlayoutError() const override {
LOG(LS_VERBOSE) << __FUNCTION__;
return false;
}
bool RecordingWarning() const override {
LOG(LS_VERBOSE) << __FUNCTION__;
return false;
}
bool RecordingError() const override {
LOG(LS_VERBOSE) << __FUNCTION__;
return false;
}

4
webrtc/modules/audio_device/audio_device_impl.cc
View File

@ -387,7 +387,6 @@ AudioDeviceModuleImpl::~AudioDeviceModuleImpl() {
// ----------------------------------------------------------------------------
int64_t AudioDeviceModuleImpl::TimeUntilNextProcess() {
LOG(LS_VERBOSE) << __FUNCTION__;
int64_t now = rtc::TimeMillis();
int64_t deltaProcess = kAdmMaxIdleTimeProcess - (now - _lastProcessTime);
return deltaProcess;
@ -401,7 +400,6 @@ int64_t AudioDeviceModuleImpl::TimeUntilNextProcess() {
// ----------------------------------------------------------------------------
void AudioDeviceModuleImpl::Process() {
LOG(LS_VERBOSE) << __FUNCTION__;
_lastProcessTime = rtc::TimeMillis();
// kPlayoutWarning
@ -1606,7 +1604,6 @@ int32_t AudioDeviceModuleImpl::PlayoutBuffer(BufferType* type,
// ----------------------------------------------------------------------------
int32_t AudioDeviceModuleImpl::PlayoutDelay(uint16_t* delayMS) const {
LOG(LS_VERBOSE) << __FUNCTION__;
CHECK_INITIALIZED();
uint16_t delay(0);
@ -1617,7 +1614,6 @@ int32_t AudioDeviceModuleImpl::PlayoutDelay(uint16_t* delayMS) const {
}
*delayMS = delay;
LOG(LS_VERBOSE) << "output: " << *delayMS;
return (0);
}