From 33bb86d5a1ec5a4aafeaea0788242bb51189d031 Mon Sep 17 00:00:00 2001 From: perkj Date: Mon, 29 May 2017 02:46:05 -0700 Subject: [PATCH] Remove final from RtcEventLogNullImpl The reason is that there might be implementations that do not want to implement all methods. To allow easier modification of the RtcEventLog interface, allow these implementation to inherit the RtcEventLogNullImpl implementation. BUG=none Review-Url: https://codereview.webrtc.org/2903003002 Cr-Commit-Position: refs/heads/master@{#18298} --- webrtc/logging/rtc_event_log/rtc_event_log.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/webrtc/logging/rtc_event_log/rtc_event_log.h b/webrtc/logging/rtc_event_log/rtc_event_log.h index 3f96556d8a..45e8bf012b 100644 --- a/webrtc/logging/rtc_event_log/rtc_event_log.h +++ b/webrtc/logging/rtc_event_log/rtc_event_log.h @@ -188,7 +188,7 @@ class RtcEventLog { }; // No-op implementation is used if flag is not set, or in tests. -class RtcEventLogNullImpl final : public RtcEventLog { +class RtcEventLogNullImpl : public RtcEventLog { public: bool StartLogging(const std::string& file_name, int64_t max_size_bytes) override {