From 33aaa35d54163a94912e4e58bcb55b61ffcf53a0 Mon Sep 17 00:00:00 2001 From: Ilya Nikolaevskiy Date: Tue, 21 Jan 2020 13:38:19 +0100 Subject: [PATCH] Fix video_replay to build and actually work Add it to default build target, so it won't get broken accidentally again. Fix configuration issue with field trials (new parameter was added recently, but wasn't set by video_replay) Bug: webrtc:11287 Change-Id: I9c18746d899acd7ac68c1b9b3a646b862c41897a Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/166900 Commit-Queue: Ilya Nikolaevskiy Reviewed-by: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#30345} --- BUILD.gn | 1 + video/BUILD.gn | 2 ++ video/video_replay.cc | 2 ++ 3 files changed, 5 insertions(+) diff --git a/BUILD.gn b/BUILD.gn index 2989440a95..7ec140396a 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -62,6 +62,7 @@ if (!build_with_chromium) { "video:screenshare_loopback", "video:sv_loopback", "video:video_loopback", + "video:video_replay", ] if (!is_asan) { # Do not build :webrtc_lib_link_test because lld complains on some OS diff --git a/video/BUILD.gn b/video/BUILD.gn index 8ed37d3843..1878f3216c 100644 --- a/video/BUILD.gn +++ b/video/BUILD.gn @@ -474,7 +474,9 @@ if (rtc_include_tests) { "../api/rtc_event_log", "../api/task_queue:default_task_queue_factory", "../api/test/video:function_video_factory", + "../api/transport:field_trial_based_config", "../api/video_codecs:video_codecs_api", + "../call", "../call:call_interfaces", "../common_video", "../media:rtc_internal_video_codecs", diff --git a/video/video_replay.cc b/video/video_replay.cc index 6562f423f0..90989db7d6 100644 --- a/video/video_replay.cc +++ b/video/video_replay.cc @@ -19,6 +19,7 @@ #include "api/rtc_event_log/rtc_event_log.h" #include "api/task_queue/default_task_queue_factory.h" #include "api/test/video/function_video_decoder_factory.h" +#include "api/transport/field_trial_based_config.h" #include "api/video_codecs/video_decoder.h" #include "call/call.h" #include "common_video/libyuv/include/webrtc_libyuv.h" @@ -267,6 +268,7 @@ class RtpReplayer final { webrtc::RtcEventLogNull event_log; Call::Config call_config(&event_log); call_config.task_queue_factory = task_queue_factory.get(); + call_config.trials = new FieldTrialBasedConfig(); std::unique_ptr call(Call::Create(call_config)); std::unique_ptr stream_state; // Attempt to load the configuration