diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn index be53e40fd9..1c2527af51 100644 --- a/webrtc/base/BUILD.gn +++ b/webrtc/base/BUILD.gn @@ -40,7 +40,7 @@ config("openssl_config") { ] } -config("no_openssl_config") { +config("nss_config") { defines = [ "SSL_USE_NSS", "HAVE_NSS_SSL_H", @@ -465,24 +465,30 @@ static_library("webrtc_base") { "opensslstreamadapter.h", ] } else { - public_configs += [ ":no_openssl_config" ] + public_configs += [ ":nss_config" ] + if (rtc_build_ssl) { + if (build_with_chromium) { + deps += [ "//crypto:platform" ] + } else { + deps += [ "//net/third_party/nss/ssl:libssl" ] + if (is_linux) { + deps += [ ":linux_system_ssl" ] + } else { + deps += [ + "//third_party/nss:nspr", + "//third_party/nss:nss", + ] + } + } + } else { + configs += [ "external_ssl_library" ] + } sources += [ "nssidentity.cc", "nssidentity.h", "nssstreamadapter.cc", "nssstreamadapter.h", ] - if (is_mac || is_ios || is_win) { - if (rtc_build_ssl) { - deps += [ - "//net/third_party/nss/ssl:libssl", - "//third_party/nss:nspr", - "//third_party/nss:nss", - ] - } else { - configs += [ "external_ssl_library" ] - } - } } if (is_android) { @@ -518,13 +524,9 @@ static_library("webrtc_base") { if (is_linux) { libs += [ - "crypto", "dl", "rt", ] - if (rtc_build_ssl) { - configs += [ "//third_party/nss:system_nss_no_ssl_config" ] - } } if (is_mac) { @@ -595,16 +597,4 @@ static_library("webrtc_base") { "linux.h", ] } - - if (is_posix && !is_mac && !is_ios && !is_android) { - if (build_with_chromium) { - deps += [ "//crypto:platform" ] - } else { - if (rtc_build_ssl) { - deps += [ ":linux_system_ssl" ] - } else { - configs += [ "external_ssl_library" ] - } - } - } } diff --git a/webrtc/base/base.gyp b/webrtc/base/base.gyp index 569db74027..2fd64ba5e2 100644 --- a/webrtc/base/base.gyp +++ b/webrtc/base/base.gyp @@ -539,32 +539,31 @@ ], }, }], - ['OS=="mac" or OS=="ios" or OS=="win"', { + ['build_ssl==1', { 'conditions': [ - ['build_ssl==1', { + # On some platforms, the rest of NSS is bundled. On others, + # it's pulled from the system. + ['OS == "mac" or OS == "ios" or OS == "win"', { 'dependencies': [ '<(DEPTH)/net/third_party/nss/ssl.gyp:libssl', '<(DEPTH)/third_party/nss/nss.gyp:nspr', '<(DEPTH)/third_party/nss/nss.gyp:nss', ], - }, { - 'include_dirs': [ - '<(ssl_root)', + }], + ['os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', { + 'dependencies': [ + '<(DEPTH)/build/linux/system.gyp:ssl', ], }], ], + }, { + 'include_dirs': [ + '<(ssl_root)', + ], }], ], }], ['OS == "android"', { - 'defines': [ - 'HAVE_OPENSSL_SSL_H' - ], - 'direct_dependent_settings': { - 'defines': [ - 'HAVE_OPENSSL_SSL_H' - ], - }, 'link_settings': { 'libraries': [ '-llog', @@ -572,20 +571,6 @@ ], }, }, { - 'conditions': [ - ['use_legacy_ssl_defaults!=1', { - 'defines': [ - 'HAVE_NSS_SSL_H', - 'SSL_USE_NSS_RNG', - ], - 'direct_dependent_settings': { - 'defines': [ - 'HAVE_NSS_SSL_H', - 'SSL_USE_NSS_RNG', - ], - }, - }], - ], 'sources!': [ 'ifaddrs-android.cc', 'ifaddrs-android.h', @@ -627,21 +612,6 @@ '-lrt', ], }, - 'conditions': [ - ['build_ssl==1', { - 'link_settings': { - 'libraries': [ - '