From 32fdb04f1f3881d1857fa39c8a76c5b3f7f07915 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Fri, 7 Jun 2024 08:09:28 +0000 Subject: [PATCH] Disable G722 and iLBC tests failing with the new version of UBSan. Bug: webrtc:345525069 Change-Id: I2d1a817b550f536cd46a0fa4c142e320e32f1701 Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/353840 Auto-Submit: Mirko Bonadei Commit-Queue: Henrik Lundin Reviewed-by: Henrik Lundin Cr-Commit-Position: refs/heads/main@{#42442} --- .../audio_coding/neteq/audio_decoder_unittest.cc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/modules/audio_coding/neteq/audio_decoder_unittest.cc b/modules/audio_coding/neteq/audio_decoder_unittest.cc index fef3c3c1e4..8db90cd4e4 100644 --- a/modules/audio_coding/neteq/audio_decoder_unittest.cc +++ b/modules/audio_coding/neteq/audio_decoder_unittest.cc @@ -455,7 +455,12 @@ TEST_F(AudioDecoderPcm16BTest, SetTargetBitrate) { codec_input_rate_hz_ * 16); } +// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove iLBC. +#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer) +TEST_F(AudioDecoderIlbcTest, DISABLED_EncodeDecode) { +#else TEST_F(AudioDecoderIlbcTest, EncodeDecode) { +#endif int tolerance = 6808; double mse = 2.13e6; int delay = 80; // Delay from input to output. @@ -469,7 +474,12 @@ TEST_F(AudioDecoderIlbcTest, SetTargetBitrate) { TestSetAndGetTargetBitratesWithFixedCodec(audio_encoder_.get(), 13333); } +// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722. +#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer) +TEST_F(AudioDecoderG722Test, DISABLED_EncodeDecode) { +#else TEST_F(AudioDecoderG722Test, EncodeDecode) { +#endif int tolerance = 6176; double mse = 238630.0; int delay = 22; // Delay from input to output. @@ -482,7 +492,12 @@ TEST_F(AudioDecoderG722Test, SetTargetBitrate) { TestSetAndGetTargetBitratesWithFixedCodec(audio_encoder_.get(), 64000); } +// TODO(bugs.webrtc.org/345525069): Either fix/enable or remove G722. +#if defined(__has_feature) && __has_feature(undefined_behavior_sanitizer) TEST_F(AudioDecoderG722StereoTest, EncodeDecode) { +#else +TEST_F(AudioDecoderG722StereoTest, DISABLED_EncodeDecode) { +#endif int tolerance = 6176; int channel_diff_tolerance = 0; double mse = 238630.0;