admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabled EndToEndTest.{ReceivesFlexfec, ReceivesFlexfecAndSendsCorrespondingRtcp, CanReceiveUlpfec} due to breakages across several platforms.

Browse Source 
Removed conditional disabling of
ReceivesFlexfecAndSendsCorrespondingRtcp on Asan, since failure occurs
at other platforms as well.

BUG=webrtc:7050
TBR=holmer@webrtc.org
NOTRY=True

Review-Url: https://codereview.webrtc.org/2651673011
Cr-Commit-Position: refs/heads/master@{#16288}
This commit is contained in:
aleloi 2017-01-26 01:43:56 -08:00 committed by Commit bot
parent d3adbfb13c
commit 327c450f99
1 changed files with 9 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
webrtc/video/end_to_end_tests.cc
View File

@ -58,16 +58,6 @@
namespace webrtc {
// Disable for Asan due to timeout, see bugs.webrtc.org/7047 for
// details.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_ReceivesFlexfecAndSendsCorrespondingRtcp \
DISABLED_ReceivesFlexfecAndSendsCorrespondingRtcp
#else
#define MAYBE_ReceivesFlexfecAndSendsCorrespondingRtcp \
ReceivesFlexfecAndSendsCorrespondingRtcp
#endif
namespace {
const char new_jb_enabled[] = "WebRTC-NewVideoJitterBuffer/Enabled/";
const char new_jb_disabled[] = "WebRTC-NewVideoJitterBuffer/Disabled/";
@ -613,7 +603,9 @@ TEST_P(EndToEndTest, ReceivesNackAndRetransmitsAudio) {
RunBaseTest(&test);
}
TEST_P(EndToEndTest, CanReceiveUlpfec) {
// Disable due to failure, see bugs.webrtc.org/7050 for
// details.
TEST_P(EndToEndTest, DISABLED_CanReceiveUlpfec) {
class UlpfecRenderObserver : public test::EndToEndTest,
public rtc::VideoSinkInterface<VideoFrame> {
public:
@ -829,12 +821,16 @@ class FlexfecRenderObserver : public test::EndToEndTest,
Random random_;
};
TEST_P(EndToEndTest, ReceivesFlexfec) {
// Disable due to failure, see bugs.webrtc.org/7050 for
// details.
TEST_P(EndToEndTest, DISABLED_ReceivesFlexfec) {
FlexfecRenderObserver test(false);
RunBaseTest(&test);
}
TEST_P(EndToEndTest, MAYBE_ReceivesFlexfecAndSendsCorrespondingRtcp) {
// Disable due to failure, see bugs.webrtc.org/7050 for
// details.
TEST_P(EndToEndTest, DISABLED_ReceivesFlexfecAndSendsCorrespondingRtcp) {
FlexfecRenderObserver test(true);
RunBaseTest(&test);
}