admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure correct destruction order in RtcEventLogImplTest

Browse Source 
Bug: b/269744492
Change-Id: I0b7b92ec31baf3515562adde7617de0873cfd537
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/298882
Reviewed-by: Markus Handell <handellm@webrtc.org>
Commit-Queue: Markus Handell <handellm@webrtc.org>
Cr-Commit-Position: refs/heads/main@{#39653}
This commit is contained in:
Björn Terelius 2023-03-23 11:52:28 +01:00 committed by WebRTC LUCI CQ
parent 342bbe1ad4
commit 31a10d321a
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
logging/rtc_event_log/rtc_event_log_impl_unittest.cc
View File

@ -98,6 +98,7 @@ class RtcEventLogImplTest : public ::testing::Test {
static constexpr Timestamp kStartTime = Timestamp::Seconds(1); static constexpr Timestamp kStartTime = Timestamp::Seconds(1);
GlobalSimulatedTimeController time_controller_{kStartTime}; GlobalSimulatedTimeController time_controller_{kStartTime};
std::string written_data_; // This must be destroyed after the event_log_.
std::unique_ptr<MockEventEncoder> encoder_ = std::unique_ptr<MockEventEncoder> encoder_ =
std::make_unique<MockEventEncoder>(); std::make_unique<MockEventEncoder>();
MockEventEncoder* encoder_ptr_ = encoder_.get(); MockEventEncoder* encoder_ptr_ = encoder_.get();
@ -107,7 +108,6 @@ class RtcEventLogImplTest : public ::testing::Test {
RtcEventLogImpl event_log_{std::move(encoder_), RtcEventLogImpl event_log_{std::move(encoder_),
time_controller_.GetTaskQueueFactory(), time_controller_.GetTaskQueueFactory(),
kMaxEventsInHistory, kMaxEventsInConfigHistory}; kMaxEventsInHistory, kMaxEventsInConfigHistory};
std::string written_data_;
}; };
TEST_F(RtcEventLogImplTest, WritesHeaderAndEventsAndTrailer) { TEST_F(RtcEventLogImplTest, WritesHeaderAndEventsAndTrailer) {