From 311c13b3c208709db92bb6a2dced6e9772be4e76 Mon Sep 17 00:00:00 2001 From: Mirko Bonadei Date: Thu, 4 Oct 2018 11:42:49 +0200 Subject: [PATCH] Remove noop system_wrappers_default build target. After the removal of field_trial_default, metrics_default and runtime_enabled_features_default, this build target doesn't build anything and can be safely removed. Bug: webrtc:9631 Change-Id: Iee1111e065ffefe0b4b9a695ee67a594e6d82caa Reviewed-on: https://webrtc-review.googlesource.com/c/103702 Reviewed-by: Oleh Prypin Commit-Queue: Mirko Bonadei Cr-Commit-Position: refs/heads/master@{#24976} --- BUILD.gn | 1 - modules/audio_coding/BUILD.gn | 8 -------- modules/audio_mixer/BUILD.gn | 1 - modules/audio_processing/BUILD.gn | 1 - modules/video_capture/BUILD.gn | 1 - rtc_tools/BUILD.gn | 3 --- sdk/BUILD.gn | 2 -- system_wrappers/BUILD.gn | 6 ------ 8 files changed, 23 deletions(-) diff --git a/BUILD.gn b/BUILD.gn index 85b0769e0f..6856cdc7a2 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -385,7 +385,6 @@ if (!build_with_chromium) { "ortc", "rtc_base", "sdk", - "system_wrappers:system_wrappers_default", "video", ] diff --git a/modules/audio_coding/BUILD.gn b/modules/audio_coding/BUILD.gn index 78d9c6e6d4..7399cb04bc 100644 --- a/modules/audio_coding/BUILD.gn +++ b/modules/audio_coding/BUILD.gn @@ -1508,7 +1508,6 @@ if (rtc_include_tests) { ":neteq_test_tools", "../..:webrtc_common", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "../../test:test_support", "//third_party/abseil-cpp/absl/memory", ] @@ -1581,7 +1580,6 @@ if (rtc_include_tests) { "../..:webrtc_common", "../../api:libjingle_peerconnection_api", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "../../test:test_main", "../audio_processing", "//testing/gtest", @@ -1656,7 +1654,6 @@ if (rtc_include_tests) { "../../api/audio_codecs/L16:audio_encoder_L16", "../../api/audio_codecs/g722:audio_encoder_g722", "../../api/audio_codecs/ilbc:audio_encoder_ilbc", - "../../system_wrappers:system_wrappers_default", "../../api/audio_codecs/isac:audio_encoder_isac", "../../api/audio_codecs/opus:audio_encoder_opus", "../../rtc_base:rtc_base_approved", @@ -1673,7 +1670,6 @@ if (rtc_include_tests) { testonly = true deps = audio_coding_deps + [ - "../../system_wrappers:system_wrappers_default", "../rtp_rtcp:rtp_rtcp_format", "../../api:array_view", "../../rtc_base:rtc_base_approved", @@ -1696,7 +1692,6 @@ if (rtc_include_tests) { deps = [ "../../rtc_base:checks", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "../../test:rtp_test_utils", "//testing/gtest", ] @@ -1714,7 +1709,6 @@ if (rtc_include_tests) { ":neteq_test_tools", ":pcm16b", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "//testing/gtest", ] } @@ -1749,7 +1743,6 @@ if (rtc_include_tests) { ":neteq_test_support", "../..:webrtc_common", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "../../test:fileutils", "../../test:test_support", ] @@ -1770,7 +1763,6 @@ if (rtc_include_tests) { "../..:webrtc_common", "../../rtc_base:checks", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", "../../test:fileutils", "../../test:test_main", "//testing/gtest", diff --git a/modules/audio_mixer/BUILD.gn b/modules/audio_mixer/BUILD.gn index bd3b106d3d..9d15c4cf46 100644 --- a/modules/audio_mixer/BUILD.gn +++ b/modules/audio_mixer/BUILD.gn @@ -111,7 +111,6 @@ if (rtc_include_tests) { "../../api/audio:audio_mixer_api", "../../common_audio", "../../rtc_base:rtc_base_approved", - "../../system_wrappers:system_wrappers_default", ] } } diff --git a/modules/audio_processing/BUILD.gn b/modules/audio_processing/BUILD.gn index 6bff6cf859..61b4d495ed 100644 --- a/modules/audio_processing/BUILD.gn +++ b/modules/audio_processing/BUILD.gn @@ -539,7 +539,6 @@ if (rtc_include_tests) { "../../rtc_base:rtc_task_queue", "../../rtc_base:stringutils", "../../system_wrappers", - "../../system_wrappers:system_wrappers_default", "../../test:test_support", "aec_dump", "aec_dump:aec_dump_impl", diff --git a/modules/video_capture/BUILD.gn b/modules/video_capture/BUILD.gn index 43987eabc0..ef6f335e49 100644 --- a/modules/video_capture/BUILD.gn +++ b/modules/video_capture/BUILD.gn @@ -190,7 +190,6 @@ if (!build_with_chromium) { "../../common_video:common_video", "../../rtc_base:rtc_base_approved", "../../system_wrappers:system_wrappers", - "../../system_wrappers:system_wrappers_default", "../../test:video_test_common", "../utility", "//testing/gtest", diff --git a/rtc_tools/BUILD.gn b/rtc_tools/BUILD.gn index 990d964321..883a46edde 100644 --- a/rtc_tools/BUILD.gn +++ b/rtc_tools/BUILD.gn @@ -221,7 +221,6 @@ if (!build_with_chromium) { deps = [ "../modules/audio_device", "../modules/audio_device:audio_device_impl", - "../system_wrappers:system_wrappers_default", ] } } @@ -279,7 +278,6 @@ if (!build_with_chromium) { "../modules/congestion_controller/goog_cc:estimators", "../modules/pacing", "../modules/rtp_rtcp", - "../system_wrappers:system_wrappers_default", "//third_party/abseil-cpp/absl/memory", ] } @@ -428,7 +426,6 @@ if (rtc_include_tests) { "../modules/audio_processing:audioproc_test_utils", "../rtc_base:protobuf_utils", "../rtc_base:rtc_base_approved", - "../system_wrappers:system_wrappers_default", ] } # unpack_aecdump } diff --git a/sdk/BUILD.gn b/sdk/BUILD.gn index 9e5f4a485c..b4f193d1f3 100644 --- a/sdk/BUILD.gn +++ b/sdk/BUILD.gn @@ -1066,7 +1066,6 @@ if (is_ios || is_mac) { "../rtc_base:rtc_base", "../rtc_base:rtc_base_tests_utils", "../system_wrappers:system_wrappers", - "../system_wrappers:system_wrappers_default", "//third_party/libyuv", ] @@ -1182,7 +1181,6 @@ if (is_ios || is_mac) { "../modules/video_coding:video_codec_interface", "../rtc_base:rtc_base_tests_utils", "../rtc_base/system:unused", - "../system_wrappers:system_wrappers_default", "//test:test_support", "//third_party/ocmock", ] diff --git a/system_wrappers/BUILD.gn b/system_wrappers/BUILD.gn index ef10fc5913..eb60052265 100644 --- a/system_wrappers/BUILD.gn +++ b/system_wrappers/BUILD.gn @@ -125,12 +125,6 @@ rtc_source_set("metrics") { ] } -group("system_wrappers_default") { - deps = [ - ":system_wrappers", - ] -} - if (is_android && !build_with_mozilla) { rtc_static_library("cpu_features_android") { sources = [