From 30bd03b81d79efa4cb324ee581fec65de1cc0265 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Patrik=20H=C3=B6glund?= Date: Tue, 19 Dec 2017 11:45:31 +0100 Subject: [PATCH] Clarify NACL dependency from peerconnection API. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also gets rid of refs to bug 7504, which is now closed. Bug: webrtc:7504 Change-Id: I105355a5372ad9c2ae8ef52ae275cb4037731c3d Reviewed-on: https://webrtc-review.googlesource.com/34643 Reviewed-by: Mirko Bonadei Commit-Queue: Patrik Höglund Cr-Commit-Position: refs/heads/master@{#21366} --- api/BUILD.gn | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/api/BUILD.gn b/api/BUILD.gn index d9d443bc75..fa93e14808 100644 --- a/api/BUILD.gn +++ b/api/BUILD.gn @@ -90,7 +90,6 @@ rtc_static_library("libjingle_peerconnection_api") { ":optional", ":rtc_stats_api", ":video_frame_api", - "../rtc_base:checks", "audio_codecs:audio_codecs_api", # Basically, don't add stuff here. You might break sensitive downstream @@ -105,11 +104,8 @@ rtc_static_library("libjingle_peerconnection_api") { "../rtc_base:rtc_base_approved", "../rtc_base:stringutils", ] - - # This is needed until bugs.webrtc.org/7504 is removed so this target can - # properly depend on ../media:rtc_media_base - # TODO(kjellander): Remove this dependency. if (is_nacl) { + # This is needed by .h files included from rtc_base. deps += [ "//native_client_sdk/src/libraries/nacl_io" ] } } @@ -119,7 +115,7 @@ rtc_source_set("peerconnection_and_implicit_call_api") { # and the entire call module with it. We need to either get rid of this # dependency or pull most of call/ into the API. For now, silence the warnings # this creates since it creates a circular dependency (call very much depends - # on API). See bugs.webrtc.org/7504. + # on API). See bugs.webrtc.org/8667. check_includes = false sources = [ "peerconnectioninterface.h",