Android: Fix synchronization problems in VideoFrame release.

Also fixes a small bug in EglRenderer where if it was passed a custom
frame, it would leak a reference.

BUG=b/64887218

Review-Url: https://codereview.webrtc.org/3003533002
Cr-Commit-Position: refs/heads/master@{#19432}

webrtc/sdk/android/api/org/webrtc/EglRenderer.java

@@ -639,7 +639,7 @@ public class EglRenderer implements VideoRenderer.Callbacks, VideoSink {
     }
 
     notifyCallbacks(frame, isYuvBuffer, yuvTextures, shouldRenderFrame);
-    frame.release();
+    buffer.release();
   }
 
   private void notifyCallbacks(

webrtc/sdk/android/src/java/org/webrtc/I420BufferImpl.java

@@ -24,6 +24,7 @@ class I420BufferImpl implements VideoFrame.I420Buffer {
   private final int strideU;
   private final int strideV;
   private final Runnable releaseCallback;
+  private final Object refCountLock = new Object();
 
   private int refCount;
 
@@ -116,13 +117,17 @@ class I420BufferImpl implements VideoFrame.I420Buffer {
 
   @Override
   public void retain() {
-    ++refCount;
+    synchronized (refCountLock) {
+      ++refCount;
+    }
   }
 
   @Override
   public void release() {
-    if (--refCount == 0 && releaseCallback != null) {
+    synchronized (refCountLock) {
-      releaseCallback.run();
+      if (--refCount == 0 && releaseCallback != null) {
+        releaseCallback.run();
+      }
     }
   }
 

webrtc/sdk/android/src/java/org/webrtc/NV12Buffer.java

@@ -19,6 +19,7 @@ public class NV12Buffer implements VideoFrame.Buffer {
   private final int sliceHeight;
   private final ByteBuffer buffer;
   private final Runnable releaseCallback;
+  private final Object refCountLock = new Object();
 
   private int refCount;
 
@@ -51,13 +52,17 @@ public class NV12Buffer implements VideoFrame.Buffer {
 
   @Override
   public void retain() {
-    refCount++;
+    synchronized (refCountLock) {
+      ++refCount;
+    }
   }
 
   @Override
   public void release() {
-    if (--refCount == 0) {
+    synchronized (refCountLock) {
-      releaseCallback.run();
+      if (--refCount == 0 && releaseCallback != null) {
+        releaseCallback.run();
+      }
     }
   }
 
@@ -75,4 +80,4 @@ public class NV12Buffer implements VideoFrame.Buffer {
       int scaleWidth, int scaleHeight, ByteBuffer src, int srcWidth, int srcHeight, int srcStride,
       int srcSliceHeight, ByteBuffer dstY, int dstStrideY, ByteBuffer dstU, int dstStrideU,
       ByteBuffer dstV, int dstStrideV);
-}
+}

webrtc/sdk/android/src/java/org/webrtc/TextureBufferImpl.java

@@ -25,6 +25,7 @@ class TextureBufferImpl implements VideoFrame.TextureBuffer {
   private final Matrix transformMatrix;
   private final SurfaceTextureHelper surfaceTextureHelper;
   private final Runnable releaseCallback;
+  private final Object refCountLock = new Object();
   private int refCount;
 
   public TextureBufferImpl(int width, int height, Type type, int id, Matrix transformMatrix,
@@ -102,13 +103,17 @@ class TextureBufferImpl implements VideoFrame.TextureBuffer {
 
   @Override
   public void retain() {
-    ++refCount;
+    synchronized (refCountLock) {
+      ++refCount;
+    }
   }
 
   @Override
   public void release() {
-    if (--refCount == 0) {
+    synchronized (refCountLock) {
-      releaseCallback.run();
+      if (--refCount == 0 && releaseCallback != null) {
+        releaseCallback.run();
+      }
     }
   }