admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fixing peerconnection reddish video issue

Browse Source 
BUG=webrtc:6857
NOTRY=True

Review-Url: https://codereview.webrtc.org/2604323002
Cr-Commit-Position: refs/heads/master@{#16143}
This commit is contained in:
mbonadei 2017-01-18 04:23:10 -08:00 committed by Commit bot
parent 5850a9484d
commit 2f67b82e20
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
webrtc/examples/peerconnection/client/linux/main_wnd.cc
View File

@ -531,7 +531,13 @@ void GtkMainWnd::VideoRenderer::OnFrame(
}
SetSize(buffer->width(), buffer->height());
libyuv::I420ToRGBA(buffer->DataY(), buffer->StrideY(),
// The order in the name of libyuv::I420To(ABGR,RGBA) is ambiguous because
// it doesn't tell you if it is referring to how it is laid out in memory as
// bytes or if endiannes is taken into account.
// This was supposed to be a call to libyuv::I420ToRGBA but it was resulting
// in a reddish video output (see https://bugs.webrtc.org/6857) because it
// was producing an unexpected byte order (ABGR, byte swapped).
libyuv::I420ToABGR(buffer->DataY(), buffer->StrideY(),
buffer->DataU(), buffer->StrideU(),
buffer->DataV(), buffer->StrideV(),
image_.get(), width_ * 4,