admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

standalone ice transport: dont use component 0

Browse Source 
0 is not valid per https://tools.ietf.org/html/rfc5245#section-15.1 which says
<component-id>:  is a positive integer between 1 and 256

This is part of the RTCIceTransport extension API which is probably going away.

BUG=chromium:1044875

Change-Id: I56d8dec79d3191e084f4a25a2c0a4d0b67afde74
Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/212642
Reviewed-by: Harald Alvestrand <hta@webrtc.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#33515}
This commit is contained in:
Philipp Hancke 2021-03-21 20:37:35 +01:00 committed by Commit Bot
parent c73257651b
commit 2f5f5fa171
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
api/ice_transport_factory.cc
View File

@ -14,6 +14,7 @@
#include <utility> #include <utility>
#include "p2p/base/ice_transport_internal.h" #include "p2p/base/ice_transport_internal.h"
#include "p2p/base/p2p_constants.h"
#include "p2p/base/p2p_transport_channel.h" #include "p2p/base/p2p_transport_channel.h"
#include "p2p/base/port_allocator.h" #include "p2p/base/port_allocator.h"
#include "rtc_base/thread.h" #include "rtc_base/thread.h"
@ -59,8 +60,8 @@ rtc::scoped_refptr<IceTransportInterface> CreateIceTransport(
IceTransportInit init) { IceTransportInit init) {
return new rtc::RefCountedObject<IceTransportWithTransportChannel>( return new rtc::RefCountedObject<IceTransportWithTransportChannel>(
std::make_unique<cricket::P2PTransportChannel>( std::make_unique<cricket::P2PTransportChannel>(
"", 0, init.port_allocator(), init.async_resolver_factory(), "", cricket::ICE_CANDIDATE_COMPONENT_RTP, init.port_allocator(),
init.event_log())); init.async_resolver_factory(), init.event_log()));
} }
} // namespace webrtc } // namespace webrtc