From 2ddf09397fa8b3864eec135b1c56cb3530dd3765 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20Bostr=C3=B6m?= Date: Wed, 20 Apr 2016 14:06:45 +0200 Subject: [PATCH] Fix missing-break-fallthrough warning. Adds a break; after RTC_NOTREACHED(). Also removes default case to catch if any other codec type is added. BUG= R=stefan@webrtc.org Review URL: https://codereview.webrtc.org/1905573002 . Cr-Commit-Position: refs/heads/master@{#12443} --- webrtc/modules/video_coding/packet_buffer.cc | 23 +++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/webrtc/modules/video_coding/packet_buffer.cc b/webrtc/modules/video_coding/packet_buffer.cc index 8cbfc0c66f..d7b4f449e7 100644 --- a/webrtc/modules/video_coding/packet_buffer.cc +++ b/webrtc/modules/video_coding/packet_buffer.cc @@ -207,25 +207,22 @@ void PacketBuffer::ManageFrame(std::unique_ptr frame) { VideoCodecType codec_type = data_buffer_[start_index].codec; switch (codec_type) { - case kVideoCodecULPFEC : - case kVideoCodecRED : - case kVideoCodecUnknown : { + case kVideoCodecULPFEC: + case kVideoCodecRED: + case kVideoCodecUnknown: RTC_NOTREACHED(); - } - case kVideoCodecVP8 : { + break; + case kVideoCodecVP8: ManageFrameVp8(std::move(frame)); break; - } - case kVideoCodecVP9 : { + case kVideoCodecVP9: // TODO(philipel): ManageFrameVp9(std::move(frame)); break; - } - case kVideoCodecH264 : - case kVideoCodecI420 : - case kVideoCodecGeneric : - default : { + case kVideoCodecH264: + case kVideoCodecI420: + case kVideoCodecGeneric: ManageFrameGeneric(std::move(frame)); - } + break; } }