diff --git a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc index f1b12f0beb..83c5441138 100644 --- a/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc +++ b/logging/rtc_event_log/encoder/rtc_event_log_encoder_legacy.cc @@ -131,9 +131,9 @@ ConvertIceCandidatePairConfigType(IceCandidatePairConfigType type) { rtclog::IceCandidatePairConfig::IceCandidateType ConvertIceCandidateType( IceCandidateType type) { switch (type) { - case IceCandidateType::kLocal: + case IceCandidateType::kHost: return rtclog::IceCandidatePairConfig::LOCAL; - case IceCandidateType::kStun: + case IceCandidateType::kSrflx: return rtclog::IceCandidatePairConfig::STUN; case IceCandidateType::kPrflx: return rtclog::IceCandidatePairConfig::PRFLX; diff --git a/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc b/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc index ebda3bfeed..7018f71e1b 100644 --- a/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc +++ b/logging/rtc_event_log/encoder/rtc_event_log_encoder_new_format.cc @@ -200,9 +200,9 @@ ConvertToProtoFormat(IceCandidatePairConfigType type) { rtclog2::IceCandidatePairConfig::IceCandidateType ConvertToProtoFormat( IceCandidateType type) { switch (type) { - case IceCandidateType::kLocal: + case IceCandidateType::kHost: return rtclog2::IceCandidatePairConfig::LOCAL; - case IceCandidateType::kStun: + case IceCandidateType::kSrflx: return rtclog2::IceCandidatePairConfig::STUN; case IceCandidateType::kPrflx: return rtclog2::IceCandidatePairConfig::PRFLX; diff --git a/logging/rtc_event_log/events/rtc_event_ice_candidate_pair_config.h b/logging/rtc_event_log/events/rtc_event_ice_candidate_pair_config.h index e77253d9fb..c8623a3010 100644 --- a/logging/rtc_event_log/events/rtc_event_ice_candidate_pair_config.h +++ b/logging/rtc_event_log/events/rtc_event_ice_candidate_pair_config.h @@ -32,13 +32,15 @@ enum class IceCandidatePairConfigType { kNumValues, }; -// TODO(tommi): Change the names of candidate types to "host", "srflx" for -// spec-compliance. +// TODO(tommi): Move this definition to candidate.h. enum class IceCandidateType { - kLocal, - kStun, + kHost, + kSrflx, kPrflx, kRelay, + // TODO(tommi): Legacy names. Remove. + kLocal [[deprecated("Use kHost instead")]] = kHost, + kStun [[deprecated("Use kSrflx instead ")]] = kSrflx }; enum class IceCandidatePairProtocol { diff --git a/logging/rtc_event_log/rtc_event_log_parser.cc b/logging/rtc_event_log/rtc_event_log_parser.cc index c53b1dd59a..d6469e1033 100644 --- a/logging/rtc_event_log/rtc_event_log_parser.cc +++ b/logging/rtc_event_log/rtc_event_log_parser.cc @@ -171,10 +171,10 @@ bool GetRuntimeIceCandidateType( IceCandidateType& parsed_type) { switch (log_type) { case rtclog::IceCandidatePairConfig::LOCAL: - parsed_type = IceCandidateType::kLocal; + parsed_type = IceCandidateType::kHost; break; case rtclog::IceCandidatePairConfig::STUN: - parsed_type = IceCandidateType::kStun; + parsed_type = IceCandidateType::kSrflx; break; case rtclog::IceCandidatePairConfig::PRFLX: parsed_type = IceCandidateType::kPrflx; @@ -813,16 +813,16 @@ IceCandidateType GetRuntimeIceCandidateType( rtclog2::IceCandidatePairConfig::IceCandidateType type) { switch (type) { case rtclog2::IceCandidatePairConfig::LOCAL: - return IceCandidateType::kLocal; + return IceCandidateType::kHost; case rtclog2::IceCandidatePairConfig::STUN: - return IceCandidateType::kStun; + return IceCandidateType::kSrflx; case rtclog2::IceCandidatePairConfig::PRFLX: return IceCandidateType::kPrflx; case rtclog2::IceCandidatePairConfig::RELAY: return IceCandidateType::kRelay; default: RTC_DCHECK_NOTREACHED(); - return IceCandidateType::kLocal; + return IceCandidateType::kHost; } } @@ -831,10 +831,10 @@ bool GetRuntimeIceCandidateType( IceCandidateType& parsed_type) { switch (log_type) { case rtclog2::IceCandidatePairConfig::LOCAL: - parsed_type = IceCandidateType::kLocal; + parsed_type = IceCandidateType::kHost; break; case rtclog2::IceCandidatePairConfig::STUN: - parsed_type = IceCandidateType::kStun; + parsed_type = IceCandidateType::kSrflx; break; case rtclog2::IceCandidatePairConfig::PRFLX: parsed_type = IceCandidateType::kPrflx; @@ -2270,13 +2270,13 @@ std::vector ParsedRtcEventLog::GetRouteChanges() if (candidate.remote_address_family == IceCandidatePairAddressFamily::kIpv6) route.send_overhead += kIpv6Overhead - kIpv4Overhead; - if (candidate.remote_candidate_type != IceCandidateType::kLocal) + if (candidate.remote_candidate_type != IceCandidateType::kHost) route.send_overhead += kStunOverhead; route.return_overhead = kUdpOverhead + kSrtpOverhead + kIpv4Overhead; if (candidate.remote_address_family == IceCandidatePairAddressFamily::kIpv6) route.return_overhead += kIpv6Overhead - kIpv4Overhead; - if (candidate.remote_candidate_type != IceCandidateType::kLocal) + if (candidate.remote_candidate_type != IceCandidateType::kHost) route.return_overhead += kStunOverhead; route_changes.push_back(route); } diff --git a/logging/rtc_event_log/rtc_event_log_unittest_helper.cc b/logging/rtc_event_log/rtc_event_log_unittest_helper.cc index be771e3cbb..bd83586456 100644 --- a/logging/rtc_event_log/rtc_event_log_unittest_helper.cc +++ b/logging/rtc_event_log/rtc_event_log_unittest_helper.cc @@ -224,10 +224,10 @@ constexpr uint32_t CandidateTypeCount() { // This switch statement only exists to catch changes to the IceCandidateType // enumeration. If you get an error here, please update the switch statement // and the return value. - IceCandidateType type = IceCandidateType::kLocal; + IceCandidateType type = IceCandidateType::kHost; switch (type) { - case IceCandidateType::kLocal: - case IceCandidateType::kStun: + case IceCandidateType::kHost: + case IceCandidateType::kSrflx: case IceCandidateType::kPrflx: case IceCandidateType::kRelay: break; @@ -237,7 +237,7 @@ constexpr uint32_t CandidateTypeCount() { std::unique_ptr EventGenerator::NewIceCandidatePairConfig() { - static_assert(static_cast(IceCandidateType::kLocal) == 0, + static_assert(static_cast(IceCandidateType::kHost) == 0, "Expect kLocal to be the first enum value, equal to 0"); IceCandidateType local_candidate_type = static_cast(prng_.Rand(CandidateTypeCount() - 1)); diff --git a/p2p/base/connection.cc b/p2p/base/connection.cc index cd5166af06..3809f12232 100644 --- a/p2p/base/connection.cc +++ b/p2p/base/connection.cc @@ -77,9 +77,9 @@ inline bool TooLongWithoutResponse( // enum. webrtc::IceCandidateType GetRtcEventLogCandidateType(const Candidate& c) { if (c.is_local()) { - return webrtc::IceCandidateType::kLocal; + return webrtc::IceCandidateType::kHost; } else if (c.is_stun()) { - return webrtc::IceCandidateType::kStun; + return webrtc::IceCandidateType::kSrflx; } else if (c.is_prflx()) { return webrtc::IceCandidateType::kPrflx; } diff --git a/rtc_tools/rtc_event_log_to_text/converter.cc b/rtc_tools/rtc_event_log_to_text/converter.cc index 79cf03ead4..3c72bfcfeb 100644 --- a/rtc_tools/rtc_event_log_to_text/converter.cc +++ b/rtc_tools/rtc_event_log_to_text/converter.cc @@ -231,8 +231,8 @@ bool Convert(std::string inputfile, {IceCandidatePairConfigType::kNumValues, "NUM_VALUES"}}; static const std::map - candidate_type_name{{IceCandidateType::kLocal, "LOCAL"}, - {IceCandidateType::kStun, "STUN"}, + candidate_type_name{{IceCandidateType::kHost, "LOCAL"}, + {IceCandidateType::kSrflx, "STUN"}, {IceCandidateType::kPrflx, "PRFLX"}, {IceCandidateType::kRelay, "RELAY"}}; diff --git a/rtc_tools/rtc_event_log_visualizer/analyzer.cc b/rtc_tools/rtc_event_log_visualizer/analyzer.cc index 33a7ce3933..0c7775e39f 100644 --- a/rtc_tools/rtc_event_log_visualizer/analyzer.cc +++ b/rtc_tools/rtc_event_log_visualizer/analyzer.cc @@ -261,9 +261,9 @@ const char kNetworkTypeCellular[] = "cellular"; absl::string_view GetIceCandidateTypeAsString(IceCandidateType type) { switch (type) { - case IceCandidateType::kLocal: + case IceCandidateType::kHost: return kIceCandidateTypeLocal; - case IceCandidateType::kStun: + case IceCandidateType::kSrflx: return kIceCandidateTypeStun; case IceCandidateType::kPrflx: return kIceCandidateTypePrflx;