From 2bac7ef2447448b81e148d3fe35badb33a4129fa Mon Sep 17 00:00:00 2001 From: philipel Date: Fri, 31 Mar 2023 15:14:20 +0200 Subject: [PATCH] Replace BuiltinVideo{Encoder,Decoder}Factory with Video{Encoder,Decoder}FactoryTemplate. Bug: webrtc:13573 Change-Id: I96e6b41b99909e5636c0044e820107c30d5f135e Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/299700 Reviewed-by: Tomas Gunnarsson Commit-Queue: Philip Eliasson Cr-Commit-Position: refs/heads/main@{#39728} --- examples/BUILD.gn | 12 ++++++++-- examples/peerconnection/client/conductor.cc | 26 +++++++++++++++++---- 2 files changed, 31 insertions(+), 7 deletions(-) diff --git a/examples/BUILD.gn b/examples/BUILD.gn index 18cb6ecc67..ea1793b8e4 100644 --- a/examples/BUILD.gn +++ b/examples/BUILD.gn @@ -754,8 +754,16 @@ if (is_linux || is_chromeos || is_win) { "../api/audio_codecs:builtin_audio_encoder_factory", "../api/video:video_frame", "../api/video:video_rtp_headers", - "../api/video_codecs:builtin_video_decoder_factory", - "../api/video_codecs:builtin_video_encoder_factory", + "../api/video_codecs:video_decoder_factory_template", + "../api/video_codecs:video_decoder_factory_template_dav1d_adapter", + "../api/video_codecs:video_decoder_factory_template_libvpx_vp8_adapter", + "../api/video_codecs:video_decoder_factory_template_libvpx_vp9_adapter", + "../api/video_codecs:video_decoder_factory_template_open_h264_adapter", + "../api/video_codecs:video_encoder_factory_template", + "../api/video_codecs:video_encoder_factory_template_libaom_av1_adapter", + "../api/video_codecs:video_encoder_factory_template_libvpx_vp8_adapter", + "../api/video_codecs:video_encoder_factory_template_libvpx_vp9_adapter", + "../api/video_codecs:video_encoder_factory_template_open_h264_adapter", "../media:rtc_audio_video", "../modules/audio_device", "../modules/audio_processing", diff --git a/examples/peerconnection/client/conductor.cc b/examples/peerconnection/client/conductor.cc index 052d417d7f..f94a981a75 100644 --- a/examples/peerconnection/client/conductor.cc +++ b/examples/peerconnection/client/conductor.cc @@ -27,10 +27,18 @@ #include "api/audio_options.h" #include "api/create_peerconnection_factory.h" #include "api/rtp_sender_interface.h" -#include "api/video_codecs/builtin_video_decoder_factory.h" -#include "api/video_codecs/builtin_video_encoder_factory.h" #include "api/video_codecs/video_decoder_factory.h" +#include "api/video_codecs/video_decoder_factory_template.h" +#include "api/video_codecs/video_decoder_factory_template_dav1d_adapter.h" +#include "api/video_codecs/video_decoder_factory_template_libvpx_vp8_adapter.h" +#include "api/video_codecs/video_decoder_factory_template_libvpx_vp9_adapter.h" +#include "api/video_codecs/video_decoder_factory_template_open_h264_adapter.h" #include "api/video_codecs/video_encoder_factory.h" +#include "api/video_codecs/video_encoder_factory_template.h" +#include "api/video_codecs/video_encoder_factory_template_libaom_av1_adapter.h" +#include "api/video_codecs/video_encoder_factory_template_libvpx_vp8_adapter.h" +#include "api/video_codecs/video_encoder_factory_template_libvpx_vp9_adapter.h" +#include "api/video_codecs/video_encoder_factory_template_open_h264_adapter.h" #include "examples/peerconnection/client/defaults.h" #include "modules/audio_device/include/audio_device.h" #include "modules/audio_processing/include/audio_processing.h" @@ -137,9 +145,17 @@ bool Conductor::InitializePeerConnection() { signaling_thread_.get(), nullptr /* default_adm */, webrtc::CreateBuiltinAudioEncoderFactory(), webrtc::CreateBuiltinAudioDecoderFactory(), - webrtc::CreateBuiltinVideoEncoderFactory(), - webrtc::CreateBuiltinVideoDecoderFactory(), nullptr /* audio_mixer */, - nullptr /* audio_processing */); + std::make_unique>(), + std::make_unique>(), + nullptr /* audio_mixer */, nullptr /* audio_processing */); if (!peer_connection_factory_) { main_wnd_->MessageBox("Error", "Failed to initialize PeerConnectionFactory",