From 2b62fa218c3af2e4ce6e4e9a6cddcc55ad07fcba Mon Sep 17 00:00:00 2001 From: deadbeef Date: Thu, 23 Feb 2017 19:05:39 -0800 Subject: [PATCH] Adding suppression for race in stats collector test. See bug for more info. This race is benign, and only exists because a method is virtual so it can be mocked for testing. BUG=webrtc:7221 NOTRY=True TBR=hbos@webrtc.org Review-Url: https://codereview.webrtc.org/2711783005 Cr-Commit-Position: refs/heads/master@{#16813} --- tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc b/tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc index b439322a54..356caf209a 100644 --- a/tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc +++ b/tools-webrtc/sanitizers/tsan_suppressions_webrtc.cc @@ -80,6 +80,11 @@ char kTSanDefaultSuppressions[] = // https://code.google.com/p/libyuv/issues/detail?id=508 "race:InitCpuFlags\n" +// Test-only race due to PeerConnection::session() being virtual for testing. +// The stats collector may call session() before or after the destructor begins +// executing, which modifies the vtable. +"race:*RTCStatsIntegrationTest_GetsStatsWhileDestroyingPeerConnections_Test::TestBody\n" + // End of suppressions. ; // Please keep this semicolon.