admin/webrtc_m130
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Disabling ScreenDrawerTest.TwoScreenDrawerLocks

Browse Source 
Test disabled on TSAN due to repeated failures. There are data races
in a low-level syncronization primitive (semaphore). Since
syncronization primitives should handle that, I think TSAN may be
configured incorrectly.

The locking scheme is written entirely in the unit test. This means we
are losing some test coverage of *unit tests*.

TBR=jamiewalch@chromium.org

Bug: webrtc:10019
Change-Id: Ieafa00a5a789acf8d0bacf6ad669c6daca7efa17
Reviewed-on: https://webrtc-review.googlesource.com/c/111585
Reviewed-by: Alex Loiko <aleloi@webrtc.org>
Commit-Queue: Alex Loiko <aleloi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#25723}
This commit is contained in:
Alex Loiko 2018-11-21 10:50:48 +01:00 committed by Commit Bot
parent c4d5642e13
commit 2b5b0e9521
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
modules/desktop_capture/screen_drawer_unittest.cc
View File

@ -140,7 +140,12 @@ TEST(ScreenDrawerTest, DISABLED_DrawRectangles) {
SleepMs(10000);
}
TEST(ScreenDrawerTest, TwoScreenDrawerLocks) {
#if defined(THREAD_SANITIZER) // bugs.webrtc.org/10019
#define MAYBE_TwoScreenDrawerLocks DISABLED_TwoScreenDrawerLocks
#else
#define MAYBE_TwoScreenDrawerLocks TwoScreenDrawerLocks
#endif
TEST(ScreenDrawerTest, MAYBE_TwoScreenDrawerLocks) {
#if defined(WEBRTC_POSIX)
// ScreenDrawerLockPosix won't be able to unlink the named semaphore. So use a
// different semaphore name here to avoid deadlock.